[PR #1277] [MERGED] feat: added support for markdown to link an image #4641

New issue

Closed

opened 2026-03-23 21:38:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1277
Author: @jedau
Created: 10/13/2022
Status: ✅ Merged
Merged: 10/15/2022
Merged by: @LucasXu0

Base: main ← Head: feat/markdown_image_1064

📝 Commits (10+)

73914a7 feat: added support for markdown to link an image
f31461b fix: fixed failing FlowyEditor test
2777386 chore: add documentation
0bba8aa chore: add documentation
47cad78 chore: update locale
a3413e8 Refactor/rename crate (#1275)
3963bd3 chore: addressed review comments
a2073ce Merge branch 'main' into feat/markdown_image_1064
86cfba2 chore: removed unused import
ed35202 fix: compile error and wrong image attributes

📊 Changes

2 files changed (+62 additions, -42 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart (+60 -39)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart (+2 -3)

📄 Description

Closes #1064

Renders image using markdown. Tested on and verified as working in the examples plugin. This PR includes:

Added handling for image markdown
Combined image and link handlers (markdownLinkToLinkHandler) because the ShortcutEvent for the two scenarios are similar
Improved RegEx for markdown links

Let me know if anyone has any questions, comments, or suggestions. I would be happy to address them all. Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1277 **Author:** [@jedau](https://github.com/jedau) **Created:** 10/13/2022 **Status:** ✅ Merged **Merged:** 10/15/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/markdown_image_1064` --- ### 📝 Commits (10+) - [`73914a7`](https://github.com/AppFlowy-IO/AppFlowy/commit/73914a77f6c471383a89c10644f283185e45d0f6) feat: added support for markdown to link an image - [`f31461b`](https://github.com/AppFlowy-IO/AppFlowy/commit/f31461bac2e007bd8ee83f10e0819aa148291700) fix: fixed failing FlowyEditor test - [`2777386`](https://github.com/AppFlowy-IO/AppFlowy/commit/277738691710db47cd3b247bd7bac90910363223) chore: add documentation - [`0bba8aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/0bba8aa4ca499d970a3115a8789d7ddd4a53926d) chore: add documentation - [`47cad78`](https://github.com/AppFlowy-IO/AppFlowy/commit/47cad7803212453d5173c8adab7b610318b7a2ee) chore: update locale - [`a3413e8`](https://github.com/AppFlowy-IO/AppFlowy/commit/a3413e83fecbd2b669a1b0baa8180610f0d00d1e) Refactor/rename crate (#1275) - [`3963bd3`](https://github.com/AppFlowy-IO/AppFlowy/commit/3963bd3e99bbac2460c31c970ecc8acd88acc486) chore: addressed review comments - [`a2073ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2073ce028e8f5b153cba7bc57f71d90b3625b12) Merge branch 'main' into feat/markdown_image_1064 - [`86cfba2`](https://github.com/AppFlowy-IO/AppFlowy/commit/86cfba20aa8bae79451e129507a12fa660b67031) chore: removed unused import - [`ed35202`](https://github.com/AppFlowy-IO/AppFlowy/commit/ed3520240f014400504de37159680e5a89cfe07c) fix: compile error and wrong image attributes ### 📊 Changes **2 files changed** (+62 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart` (+60 -39) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart` (+2 -3) </details> ### 📄 Description Closes #1064 Renders image using markdown. Tested on and verified as working in the examples plugin. This PR includes: - Added handling for image markdown - Combined image and link handlers (`markdownLinkToLinkHandler`) because the `ShortcutEvent` for the two scenarios are similar - Improved RegEx for markdown links Let me know if anyone has any questions, comments, or suggestions. I would be happy to address them all. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>