[PR #4641] [MERGED] feat: HHmm to HH:mm conversion in time field #6363

New issue

Closed

opened 2026-03-23 22:22:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4641
Author: @AnsahMohammad
Created: 2/10/2024
Status: ✅ Merged
Merged: 2/19/2024
Merged by: @LucasXu0

Base: main ← Head: time_format

📝 Commits (4)

1ce04c8 feat: add a HHmm to HH:mm function
604a9d1 fix: Replaced string.parse() with string.parseStrict() to address time input bug
38f6f12 feat: add TextFormatter for formatting the time input
a3c823a chore: Merge main

📊 Changes

3 files changed (+48 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/time_text_field.dart (+43 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+3 -0)

📄 Description

Feature Preview

Screencast from 10-02-24 02:17:46 PM IST.webm

This PR Closes #4145

I believe there might be a more efficient approach for this. I tried to utilize the 'HHmm' format directly but encountered some errors. I'm open to suggestions.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4641 **Author:** [@AnsahMohammad](https://github.com/AnsahMohammad) **Created:** 2/10/2024 **Status:** ✅ Merged **Merged:** 2/19/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `time_format` --- ### 📝 Commits (4) - [`1ce04c8`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ce04c8220b078fb3e92fb59caff76a869dd56f3) feat: add a HHmm to HH:mm function - [`604a9d1`](https://github.com/AppFlowy-IO/AppFlowy/commit/604a9d164eed121a47e195ca1e489ef8c6705a0e) fix: Replaced string.parse() with string.parseStrict() to address time input bug - [`38f6f12`](https://github.com/AppFlowy-IO/AppFlowy/commit/38f6f12f9e4515713242ff7068a487537a1191ee) feat: add TextFormatter for formatting the time input - [`a3c823a`](https://github.com/AppFlowy-IO/AppFlowy/commit/a3c823ae41a4106778ac7703c139f997dc82c0c5) chore: Merge main ### 📊 Changes **3 files changed** (+48 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/time_text_field.dart` (+43 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+3 -0) </details> ### 📄 Description ### Feature Preview [Screencast from 10-02-24 02:17:46 PM IST.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/85027826/0aa8d904-6aef-41dc-8d2e-045a6ce1be44) This PR Closes #4145 --- I believe there might be a more efficient approach for this. I tried to utilize the 'HHmm' format directly but encountered some errors. I'm open to suggestions. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>