[PR #1353] [MERGED] fix: remove attribute if it already exists on the node #4678

New issue

Closed

opened 2026-03-23 21:38:51 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1353
Author: @alemoreau
Created: 10/24/2022
Status: ✅ Merged
Merged: 10/25/2022
Merged by: @LucasXu0

Base: main ← Head: fix-undo_quote_doesnt_work

📝 Commits (2)

5d2ff8e fix: remove attribute if it already exists on the node
50814b2 test: add test for format_rich_text_style.dart

📊 Changes

2 files changed (+50 additions, -1 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart (+14 -1)
➕ frontend/app_flowy/packages/appflowy_editor/test/service/default_text_operations/format_rich_text_style_test.dart (+36 -0)

📄 Description

I tried to tackle this issue https://github.com/AppFlowy-IO/AppFlowy/issues/1325.
Hopefully it is the correct way to fix it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1353 **Author:** [@alemoreau](https://github.com/alemoreau) **Created:** 10/24/2022 **Status:** ✅ Merged **Merged:** 10/25/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-undo_quote_doesnt_work` --- ### 📝 Commits (2) - [`5d2ff8e`](https://github.com/AppFlowy-IO/AppFlowy/commit/5d2ff8e07c1d997a1d3fdb65fc29cb8d09fedf04) fix: remove attribute if it already exists on the node - [`50814b2`](https://github.com/AppFlowy-IO/AppFlowy/commit/50814b2bee4b684fb6899f88de59815446261b7e) test: add test for format_rich_text_style.dart ### 📊 Changes **2 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart` (+14 -1) ➕ `frontend/app_flowy/packages/appflowy_editor/test/service/default_text_operations/format_rich_text_style_test.dart` (+36 -0) </details> ### 📄 Description I tried to tackle this issue https://github.com/AppFlowy-IO/AppFlowy/issues/1325. Hopefully it is the correct way to fix it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>