[PR #4678] [MERGED] chore: re-implement get_filter_by_field_id function #6382

New issue

Closed

opened 2026-03-23 22:22:58 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4678
Author: @richardshiue
Created: 2/19/2024
Status: ✅ Merged
Merged: 2/22/2024
Merged by: @appflowy

Base: main ← Head: chore/remove-inaccurate-filter-function

📝 Commits (3)

a0955a1 chore: remove inaccurate database view function
f56ec90 chore: update collab rev
e8a7ed5 chore: fix clippy

📊 Changes

11 files changed (+49 additions, -46 deletions)

View changed files

📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+7 -7)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+7 -7)
📝 frontend/appflowy_web/wasm-libs/Cargo.toml (+7 -7)
📝 frontend/rust-lib/Cargo.lock (+7 -7)
📝 frontend/rust-lib/Cargo.toml (+7 -7)
📝 frontend/rust-lib/collab-integrate/src/native/plugin_provider.rs (+2 -2)
📝 frontend/rust-lib/flowy-core/src/integrate/trait_impls.rs (+5 -5)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+3 -1)
📝 frontend/rust-lib/flowy-document/tests/document/util.rs (+1 -1)
📝 frontend/rust-lib/flowy-folder/src/manager.rs (+1 -1)
📝 frontend/rust-lib/flowy-user/src/user_manager/manager_user_awareness.rs (+2 -1)

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/158

for more information, please refer to that PR. I move the logic to find the first filter whose field_id matches here in flowy_database2 so that it's clear that the field_id is defined in flowy_database2::Filter

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4678 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/19/2024 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `chore/remove-inaccurate-filter-function` --- ### 📝 Commits (3) - [`a0955a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/a0955a16dd8c8c9134832ec6c181db5d36522ead) chore: remove inaccurate database view function - [`f56ec90`](https://github.com/AppFlowy-IO/AppFlowy/commit/f56ec9047eef598804eaf30f95bf843f682f5791) chore: update collab rev - [`e8a7ed5`](https://github.com/AppFlowy-IO/AppFlowy/commit/e8a7ed5f2b9f77e5794d85f7636f3026c06f9e8a) chore: fix clippy ### 📊 Changes **11 files changed** (+49 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+7 -7) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+7 -7) 📝 `frontend/appflowy_web/wasm-libs/Cargo.toml` (+7 -7) 📝 `frontend/rust-lib/Cargo.lock` (+7 -7) 📝 `frontend/rust-lib/Cargo.toml` (+7 -7) 📝 `frontend/rust-lib/collab-integrate/src/native/plugin_provider.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-core/src/integrate/trait_impls.rs` (+5 -5) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+3 -1) 📝 `frontend/rust-lib/flowy-document/tests/document/util.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-folder/src/manager.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-user/src/user_manager/manager_user_awareness.rs` (+2 -1) </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/158 for more information, please refer to that PR. I move the logic to find the first filter whose `field_id` matches here in `flowy_database2` so that it's clear that the `field_id` is defined in `flowy_database2::Filter` ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>