[PR #1981] [MERGED] Improvement for cover plugin #1928 #5047

Closed
opened 2026-03-23 22:16:58 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1981
Author: @rizwan3395
Created: 3/12/2023
Status: Merged
Merged: 3/15/2023
Merged by: @LucasXu0

Base: mainHead: improvement_for_cover_plugin_1928


📝 Commits (9)

  • c85c6dc feat: added emoji and network image support
  • d48c3e0 fix: translations added
  • 90dc7cf fix: code cleanup and improvements
  • 650b84a chore: merge with main
  • 327ac81 fix: blank preview on invalid image save
  • 3e33b05 fix: flutter analyzer warnings
  • 9a51183 fix: code refactor and bug fixes
  • f6cbd3d chore: removed unused imports
  • 4968812 chore: formate code

📊 Changes

10 files changed (+891 additions, -99 deletions)

View changed files

frontend/appflowy_flutter/assets/images/Local Disk (C) - Shortcut.lnk (+0 -0)
frontend/appflowy_flutter/assets/images/folder.svg (+5 -0)
📝 frontend/appflowy_flutter/assets/translations/en.json (+14 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart (+35 -52)
frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_image_picker.dart (+254 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_image_picker_bloc.dart (+196 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart (+233 -46)
frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/emoji_popover.dart (+92 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/icon_widget.dart (+61 -0)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -0)

📄 Description

Description

Improve user experience for cover plugin. Added the support to add emoji and use images from URL as cover.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tap add icon. A menu pops up. Select emoji. Menu closes and displays emoji.
  • Tap Emoji icon. A menu pops up. Select emoji. Menu closes and emoji updates.
  • Tap Emoji icon. A menu pops up. Tap remove icon. Menu closes and emoji gets deleted
  • Tap change cover. Tap add image box. The dialog changes. Paste a valid URL. Image preview shows. Tap Save to gallery previous dialog displays and images is added to the gallery.
  • Tap change cover. Tap add image box. The dialog changes. Paste a in valid URL. No previews show. Error message gets displayed
  • Tap change cover. Tap add image box. The dialog changes. Tap pick from files. File browser opens.. Select any image. Displays preview. Tap Tap Save to gallery previous dialog displays and images is added to the gallery.
  • Tap Back the dialog goes back to gallery
  • When an image is picked and being previewed. Tap Close icon. The image preview gets deleted

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1981 **Author:** [@rizwan3395](https://github.com/rizwan3395) **Created:** 3/12/2023 **Status:** ✅ Merged **Merged:** 3/15/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `improvement_for_cover_plugin_1928` --- ### 📝 Commits (9) - [`c85c6dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/c85c6dcfe8bf0cd2242c5ee755bcc9b4e4205905) feat: added emoji and network image support - [`d48c3e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/d48c3e0734d83f229141f7e34ed0e596a4666dca) fix: translations added - [`90dc7cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/90dc7cf303027fb829a515170d9047195b426e68) fix: code cleanup and improvements - [`650b84a`](https://github.com/AppFlowy-IO/AppFlowy/commit/650b84a801431a9701823e3d9728b8b2864343ca) chore: merge with main - [`327ac81`](https://github.com/AppFlowy-IO/AppFlowy/commit/327ac81a55f0e5357278a9097a94f28ed523278a) fix: blank preview on invalid image save - [`3e33b05`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e33b0595ec27f0de1e1df2f9333eb720c7555f3) fix: flutter analyzer warnings - [`9a51183`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a51183f1c34102c461f5c1b1d5eb069c2783a48) fix: code refactor and bug fixes - [`f6cbd3d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f6cbd3d9a6a9b19f0b7751ff91ecc64c2b3867cf) chore: removed unused imports - [`4968812`](https://github.com/AppFlowy-IO/AppFlowy/commit/49688123554539db623046c41061b0692635339f) chore: formate code ### 📊 Changes **10 files changed** (+891 additions, -99 deletions) <details> <summary>View changed files</summary> ➖ `frontend/appflowy_flutter/assets/images/Local Disk (C) - Shortcut.lnk` (+0 -0) ➕ `frontend/appflowy_flutter/assets/images/folder.svg` (+5 -0) 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+14 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart` (+35 -52) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_image_picker.dart` (+254 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_image_picker_bloc.dart` (+196 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart` (+233 -46) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/emoji_popover.dart` (+92 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/icon_widget.dart` (+61 -0) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -0) </details> ### 📄 Description ## Description Improve user experience for cover plugin. Added the support to add emoji and use images from URL as cover. ## Type of change - [ ] New feature (non-breaking change which adds functionality) # How Has This Been Tested? - [ ] Tap `add icon`. A menu pops up. Select emoji. Menu closes and displays emoji. - [ ] Tap Emoji icon. A menu pops up. Select emoji. Menu closes and emoji updates. - [ ] Tap Emoji icon. A menu pops up. Tap `remove icon`. Menu closes and emoji gets deleted - [ ] Tap `change cover`. Tap add image box. The dialog changes. Paste a valid URL. Image preview shows. Tap `Save to gallery` previous dialog displays and images is added to the gallery. - [ ] Tap `change cover`. Tap add image box. The dialog changes. Paste a in valid URL. No previews show. Error message gets displayed - [ ] Tap `change cover`. Tap add image box. The dialog changes. Tap `pick from files`. File browser opens.. Select any image. Displays preview. Tap Tap `Save to gallery` previous dialog displays and images is added to the gallery. - [ ] Tap `Back` the dialog goes back to gallery - [ ] When an image is picked and being previewed. Tap Close icon. The image preview gets deleted # Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:16:58 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5047
No description provided.