[PR #2096] [MERGED] Fix: #2028 auto enter edit mode for text field. #5091

New issue

Closed

opened 2026-03-23 22:17:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2096
Author: @not-shoyo
Created: 3/23/2023
Status: ✅ Merged
Merged: 3/27/2023
Merged by: @LucasXu0

Base: main ← Head: fix#2028

📝 Commits (8)

1c49abf chore(): initial commit to make AppFlowy Work
9735615 fix: #2028, fix auto-entering edit mode
080b452 chore: Merge branch 'main' of https://github.com/not-shoyo/AppFlowy
bab3f5b chore: Merge branch 'main' into fix#2028
ccd1b84 Update section.dart
5145b55 Update input_service.dart
0aac57b Update input_service.dart
54d9152 Update input_service.dart

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/section.dart (+0 -1)

📄 Description

Result

https://user-images.githubusercontent.com/73631606/227256009-4449cb19-f54b-4b07-90ff-a453d206ca07.mp4

Changes

Going through the code base I noticed that whenever popovermutex underwent a change, if the focus was already on the text field, it would then revoke the focus so that the focus shifts to the popover.
What this meant was however, that if focus is on textfield, it is unfocused, however no such request of focus was coming from the text field itself.
By adding a logical else block and requesting focus whenever mutex changes, we can ensure the focus defaults back to text field.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2096 **Author:** [@not-shoyo](https://github.com/not-shoyo) **Created:** 3/23/2023 **Status:** ✅ Merged **Merged:** 3/27/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix#2028` --- ### 📝 Commits (8) - [`1c49abf`](https://github.com/AppFlowy-IO/AppFlowy/commit/1c49abf28c68cf3bbc5f6e6ac5b4aac80375048c) chore(): initial commit to make AppFlowy Work - [`9735615`](https://github.com/AppFlowy-IO/AppFlowy/commit/973561544dd1d98a7f183ebf30aebab87c57df88) fix: #2028, fix auto-entering edit mode - [`080b452`](https://github.com/AppFlowy-IO/AppFlowy/commit/080b452f2f350956cbebe3f936166100e3c2e8ff) chore: Merge branch 'main' of https://github.com/not-shoyo/AppFlowy - [`bab3f5b`](https://github.com/AppFlowy-IO/AppFlowy/commit/bab3f5bb34616472b79f906a4484106841c0c019) chore: Merge branch 'main' into fix#2028 - [`ccd1b84`](https://github.com/AppFlowy-IO/AppFlowy/commit/ccd1b840598c71d11c53fb14ee963117d9258e7f) Update section.dart - [`5145b55`](https://github.com/AppFlowy-IO/AppFlowy/commit/5145b551a0bf64a6a3a30009ecf6d9fc4e60b445) Update input_service.dart - [`0aac57b`](https://github.com/AppFlowy-IO/AppFlowy/commit/0aac57b7a1facdb944c7a62073f66f702dd49949) Update input_service.dart - [`54d9152`](https://github.com/AppFlowy-IO/AppFlowy/commit/54d91521fb66154441e4708bee5a19b4794e0bd9) Update input_service.dart ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/section.dart` (+0 -1) </details> ### 📄 Description ## Result https://user-images.githubusercontent.com/73631606/227256009-4449cb19-f54b-4b07-90ff-a453d206ca07.mp4 ## Changes - Going through the code base I noticed that whenever popovermutex underwent a change, if the focus was already on the text field, it would then revoke the focus so that the focus shifts to the popover. - What this meant was however, that if focus is on textfield, it is unfocused, however no such request of focus was coming from the text field itself. - By adding a logical else block and requesting focus whenever mutex changes, we can ensure the focus defaults back to text field. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>