[PR #2099] [MERGED] Feat(appflowy_flutter): dark mode improvement for generic area/widgets #5093

Closed
opened 2026-03-23 22:17:11 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2099
Author: @hyj1204
Created: 3/23/2023
Status: Merged
Merged: 3/30/2023
Merged by: @LucasXu0

Base: mainHead: feat/dark_mode_improvement


📝 Commits (10+)

  • 5c50abf chore: update color scheme for dark mode
  • 65df20f chore: update dark color scheme
  • 15e84c7 chore: update top bar BGcolor and icon color
  • 9bc061b chore: update text color
  • e17029a chore: update share button color on the top bar
  • f31c814 chore: add tooltip theme data in global
  • 5c09e33 chore: add hint and tertiary color and update font size pop up menu style
  • 36fe251 chore: update all the semibold texts color
  • edfe2c9 chore: update all the hover color
  • eec7e68 chore: update setting BG color

📊 Changes

71 files changed (+446 additions, -228 deletions)

View changed files

frontend/appflowy_flutter/assets/images/home/new_app_dark.svg (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/toolbar/board_setting.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/choicechip.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/create_filter_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/disclosure_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/filter_menu.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/footer/grid_footer.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_option_editor.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/number.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/action.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/create_sort_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/sort_editor.dart (+3 -3)

...and 51 more files

📄 Description

This PR is the first part of the dark mode improvement #1671 . It update the UI in the generic area/widgets, like Side bar, Top bar, question bubble and tool tip #2016 . The page area where plugins is haven't been updated. It will be updated in the next PR.

The main change
Due to the icon color on the button needs to change when it is hovered, I created a new widget FlowySvg to replace svg Widget(where has hover effect) in order to get the icon color when it is hovered from current theme data.
image

And inside FlowyHoverContainer, the icon color in the ThemeData will be updated to the new icon color(when it is hovered).
image
To clarify, the icon's color will be based on the current ThemeData when it is not being hovered over. However, when the user hovers over the icon, its color will temporarily change to a new color while still being based on the ThemeData. This allows the icon's color to be dynamically changed.

The following UI has been updated

  1. All the elements in the Side bar
    image

  2. Hover effect in multiple locations
    image
    image
    image

  3. Font size switch menu
    image

  4. All the Tooltip
    image

  5. Question bubble
    image

  6. Setting Menu and DropdownMenuItem style
    image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2099 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 3/23/2023 **Status:** ✅ Merged **Merged:** 3/30/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/dark_mode_improvement` --- ### 📝 Commits (10+) - [`5c50abf`](https://github.com/AppFlowy-IO/AppFlowy/commit/5c50abfb0434f6b8fd6708125fbfe67eb68f0d34) chore: update color scheme for dark mode - [`65df20f`](https://github.com/AppFlowy-IO/AppFlowy/commit/65df20f14a1a1fdbb53c49a120f8e7740dd8eb18) chore: update dark color scheme - [`15e84c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/15e84c7210143c6477c0f5f6bab6f5637ac11c85) chore: update top bar BGcolor and icon color - [`9bc061b`](https://github.com/AppFlowy-IO/AppFlowy/commit/9bc061b9d8bdd7405033797ea3f4abae342896de) chore: update text color - [`e17029a`](https://github.com/AppFlowy-IO/AppFlowy/commit/e17029aea655b38de6f51a6b603b0d2534789a03) chore: update share button color on the top bar - [`f31c814`](https://github.com/AppFlowy-IO/AppFlowy/commit/f31c8146e67b648512e6c2f4e185b39473f68512) chore: add tooltip theme data in global - [`5c09e33`](https://github.com/AppFlowy-IO/AppFlowy/commit/5c09e336c87e5d9f62bf68e03bb90b9b6f54eff1) chore: add hint and tertiary color and update font size pop up menu style - [`36fe251`](https://github.com/AppFlowy-IO/AppFlowy/commit/36fe251945a7c3d2e5741165c0a6f313c5f78b0c) chore: update all the semibold texts color - [`edfe2c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/edfe2c901250e07da55e7cfb4a3810c48ff8c6ce) chore: update all the hover color - [`eec7e68`](https://github.com/AppFlowy-IO/AppFlowy/commit/eec7e6817a0436f4bd2f9f34d316547568c1ef9e) chore: update setting BG color ### 📊 Changes **71 files changed** (+446 additions, -228 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/images/home/new_app_dark.svg` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/toolbar/board_setting.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/choicechip.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/create_filter_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/disclosure_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/filter_menu.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/footer/grid_footer.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_option_editor.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/number.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/action.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/create_sort_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/sort_editor.dart` (+3 -3) _...and 51 more files_ </details> ### 📄 Description This PR is the first part of the dark mode improvement #1671 . It update the UI in the generic area/widgets, like Side bar, Top bar, question bubble and tool tip #2016 . The page area where plugins is haven't been updated. It will be updated in the next PR. **The main change** Due to the icon color on the button needs to change when it is hovered, I created a new widget `FlowySvg` to replace `svg Widget`(where has hover effect) in order to get the icon color when it is hovered from current theme data. ![image](https://user-images.githubusercontent.com/14248245/228097276-404104f7-dc53-4512-b580-e05e3c42eba9.png) And inside `FlowyHoverContainer`, the icon color in the ThemeData will be updated to the new icon color(when it is hovered). ![image](https://user-images.githubusercontent.com/14248245/228097492-a1ab149f-89ba-4d3e-943f-13858e4d581d.png) To clarify, the icon's color will be based on the current ThemeData when it is not being hovered over. However, when the user hovers over the icon, its color will temporarily change to a new color while still being based on the ThemeData. This allows the icon's color to be dynamically changed. The following UI has been updated 1. All the elements in the Side bar ![image](https://user-images.githubusercontent.com/14248245/228095130-bc0f9317-882d-4de8-a146-a035db1365d9.png) 2. Hover effect in multiple locations ![image](https://user-images.githubusercontent.com/14248245/228095302-33d8316e-6d6a-4e62-a5e7-4d579947ab2f.png) ![image](https://user-images.githubusercontent.com/14248245/228095345-b0ba1d66-cd82-4401-81b8-dc4948b3636f.png) ![image](https://user-images.githubusercontent.com/14248245/228095396-67f09b5b-503d-4eb1-a28a-3ac9a7170dbe.png) 3. Font size switch menu ![image](https://user-images.githubusercontent.com/14248245/228095486-9689a81c-4c85-4755-9cdc-639fcabf5b84.png) 4. All the Tooltip ![image](https://user-images.githubusercontent.com/14248245/228095541-4a14b3e1-16f9-49c6-bf4d-228d8087a50f.png) 5. Question bubble ![image](https://user-images.githubusercontent.com/14248245/228370748-aff641dd-8b94-4993-b68d-9356d99d0306.png) 6. Setting Menu and DropdownMenuItem style ![image](https://user-images.githubusercontent.com/14248245/228674010-51d71fb8-be07-48eb-a359-7d468a1ca0ec.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:17:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5093
No description provided.