mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 04:46:56 +00:00
[PR #2099] [MERGED] Feat(appflowy_flutter): dark mode improvement for generic area/widgets #5093
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#5093
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2099
Author: @hyj1204
Created: 3/23/2023
Status: ✅ Merged
Merged: 3/30/2023
Merged by: @LucasXu0
Base:
main← Head:feat/dark_mode_improvement📝 Commits (10+)
5c50abfchore: update color scheme for dark mode65df20fchore: update dark color scheme15e84c7chore: update top bar BGcolor and icon color9bc061bchore: update text colore17029achore: update share button color on the top barf31c814chore: add tooltip theme data in global5c09e33chore: add hint and tertiary color and update font size pop up menu style36fe251chore: update all the semibold texts coloredfe2c9chore: update all the hover coloreec7e68chore: update setting BG color📊 Changes
71 files changed (+446 additions, -228 deletions)
View changed files
➕
frontend/appflowy_flutter/assets/images/home/new_app_dark.svg(+5 -0)📝
frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart(+2 -2)📝
frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/toolbar/board_setting.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/choicechip.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/create_filter_list.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/disclosure_button.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/filter_menu.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/footer/grid_footer.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_list.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_option_editor.dart(+2 -2)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart(+2 -2)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/number.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart(+2 -2)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/action.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/create_sort_list.dart(+1 -1)📝
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/sort_editor.dart(+3 -3)...and 51 more files
📄 Description
This PR is the first part of the dark mode improvement #1671 . It update the UI in the generic area/widgets, like Side bar, Top bar, question bubble and tool tip #2016 . The page area where plugins is haven't been updated. It will be updated in the next PR.
The main change

Due to the icon color on the button needs to change when it is hovered, I created a new widget
FlowySvgto replacesvg Widget(where has hover effect) in order to get the icon color when it is hovered from current theme data.And inside

FlowyHoverContainer, the icon color in the ThemeData will be updated to the new icon color(when it is hovered).To clarify, the icon's color will be based on the current ThemeData when it is not being hovered over. However, when the user hovers over the icon, its color will temporarily change to a new color while still being based on the ThemeData. This allows the icon's color to be dynamically changed.
The following UI has been updated
All the elements in the Side bar

Hover effect in multiple locations



Font size switch menu

All the Tooltip

Question bubble

Setting Menu and DropdownMenuItem style

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.