[PR #2337] [MERGED] revert: "Fix: #2028 auto enter edit mode for text field." #5189

New issue

Closed

opened 2026-03-23 22:17:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2337
Author: @richardshiue
Created: 4/23/2023
Status: ✅ Merged
Merged: 4/29/2023
Merged by: @appflowy

Base: main ← Head: revert-2096-fix#2028

📝 Commits (2)

46454df Revert "Fix: #2028 auto enter edit mode for text field. (#2096)"
c9718d8 Merge branch 'AppFlowy-IO:main' into revert-2096-fix#2028

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+0 -2)

📄 Description

The original commit has some visible regressions. See the video below:

https://user-images.githubusercontent.com/71320345/233851095-733b3c3a-621c-437b-aa9c-58fd41cf3b56.mp4

when switching from one popover to another, notice that the text field is stealing focus
the select option editor popover isn't opening at all

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2337 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 4/23/2023 **Status:** ✅ Merged **Merged:** 4/29/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `revert-2096-fix#2028` --- ### 📝 Commits (2) - [`46454df`](https://github.com/AppFlowy-IO/AppFlowy/commit/46454dff952d3298144bdbca91297418f82fa5b1) Revert "Fix: #2028 auto enter edit mode for text field. (#2096)" - [`c9718d8`](https://github.com/AppFlowy-IO/AppFlowy/commit/c9718d876a12219a44907cce1795b05d2f618fe2) Merge branch 'AppFlowy-IO:main' into revert-2096-fix#2028 ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+0 -2) </details> ### 📄 Description The original commit has some visible regressions. See the video below: https://user-images.githubusercontent.com/71320345/233851095-733b3c3a-621c-437b-aa9c-58fd41cf3b56.mp4 - when switching from one popover to another, notice that the text field is stealing focus - the select option editor popover isn't opening at all --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>