[PR #2730] [MERGED] Support text block add `link` #5398

New issue

Closed

opened 2026-03-23 22:18:34 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2730
Author: @qinluhe
Created: 6/7/2023
Status: ✅ Merged
Merged: 6/13/2023
Merged by: @qinluhe

Base: main ← Head: feat/text-block-link

📝 Commits (6)

aaf4ad8 feat: support text block href attribute
a4dad3c fix: double click didn't select range
cdefd74 fix: link update
8c6941c chore: ts lint
eb8ae90 chore: add new line
da42b11 chore: update get word indices function

📊 Changes

45 files changed (+981 additions, -210 deletions)

View changed files

📝 frontend/appflowy_tauri/src/appflowy_app/components/document/BlockSelection/BlockRangeSelection.hooks.ts (+4 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/BlockSelection/RangeKeyDown.hooks.ts (+6 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/CodeBlock/index.tsx (+4 -4)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/Node/index.tsx (+10 -7)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/Overlay/index.tsx (+2 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/index.hooks.ts (+1 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/index.tsx (+19 -10)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/FormatButton.tsx (+23 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/FormatIcon.tsx (+13 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/index.hooks.ts (+4 -3)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/index.tsx (+1 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/index.tsx (+2 -10)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/useKeyDown.ts (+0 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/useTurnIntoBlockEvents.ts (+3 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/EditorHooks/useSelection.ts (+12 -9)
➕ frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/Message/index.tsx (+47 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/CodeEditor.tsx (+6 -7)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/CodeElements.tsx (+1 -43)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/TextEditor.tsx (+3 -6)
📝 frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/TextLeaf.tsx (+55 -23)

...and 25 more files

📄 Description

Feature Preview

Support add link from text action
Support update link from hover link element
Support remove link

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2730 **Author:** [@qinluhe](https://github.com/qinluhe) **Created:** 6/7/2023 **Status:** ✅ Merged **Merged:** 6/13/2023 **Merged by:** [@qinluhe](https://github.com/qinluhe) **Base:** `main` ← **Head:** `feat/text-block-link` --- ### 📝 Commits (6) - [`aaf4ad8`](https://github.com/AppFlowy-IO/AppFlowy/commit/aaf4ad864124a45157dcc848d3644f8e1fa4dd70) feat: support text block href attribute - [`a4dad3c`](https://github.com/AppFlowy-IO/AppFlowy/commit/a4dad3c65461cdaff410211cf2c9de2c9adb9741) fix: double click didn't select range - [`cdefd74`](https://github.com/AppFlowy-IO/AppFlowy/commit/cdefd748949ec446c6348b02d8bb8c17211062fb) fix: link update - [`8c6941c`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c6941c5f06d56d7ef63a287a43a647ac5b159e8) chore: ts lint - [`eb8ae90`](https://github.com/AppFlowy-IO/AppFlowy/commit/eb8ae90155258c2b99615896362c2b02e6279051) chore: add new line - [`da42b11`](https://github.com/AppFlowy-IO/AppFlowy/commit/da42b1198223829e62a92804e7cd5e2fe443a5f4) chore: update get word indices function ### 📊 Changes **45 files changed** (+981 additions, -210 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/BlockSelection/BlockRangeSelection.hooks.ts` (+4 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/BlockSelection/RangeKeyDown.hooks.ts` (+6 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/CodeBlock/index.tsx` (+4 -4) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/Node/index.tsx` (+10 -7) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/Overlay/index.tsx` (+2 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/index.hooks.ts` (+1 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/index.tsx` (+19 -10) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/FormatButton.tsx` (+23 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/FormatIcon.tsx` (+13 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/index.hooks.ts` (+4 -3) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextActionMenu/menu/index.tsx` (+1 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/index.tsx` (+2 -10) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/useKeyDown.ts` (+0 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/TextBlock/useTurnIntoBlockEvents.ts` (+3 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/EditorHooks/useSelection.ts` (+12 -9) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/Message/index.tsx` (+47 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/CodeEditor.tsx` (+6 -7) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/CodeElements.tsx` (+1 -43) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/TextEditor.tsx` (+3 -6) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/document/_shared/SlateEditor/TextLeaf.tsx` (+55 -23) _...and 25 more files_ </details> ### 📄 Description   ### Feature Preview - [x] Support add `link` from text action - [x] Support update `link` from hover link element - [x] Support remove link ![Kapture 2023-06-08 at 17 00 46](https://github.com/AppFlowy-IO/AppFlowy/assets/108015703/cf321483-6a17-4ec9-ac7e-badbd3a47623)  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>