[PR #2791] [MERGED] chore: some ui improvements #5423

New issue

Closed

opened 2026-03-23 22:18:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2791
Author: @richardshiue
Created: 6/13/2023
Status: ✅ Merged
Merged: 6/16/2023
Merged by: @appflowy

Base: main ← Head: ui

📝 Commits (9)

40c5f78 chore: some ui improvements
2ae2c72 fix: integration test
1fdc3e3 feat: language selector on welcome page (#2796)
8c2b20d feat: row document (#2792)
16a5c7c test: fix test
22def51 test: add create select option test
d2f7c58 chore: Merge branch 'main' into ui
1499e53 chore: Merge branch 'main' into ui
97ab14c chore: Merge branch 'main' into ui

📊 Changes

13 files changed (+137 additions, -60 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+25 -0)
📝 frontend/appflowy_flutter/integration_test/database_row_page_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+72 -8)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+8 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_option_editor.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart (+4 -15)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart (+7 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart (+9 -12)

📄 Description

A couple of UI improvements in the grid UI:

Remove hack for https://github.com/flutter/flutter/issues/18761 . Due to the removal of the hack that adds a zero-width space before every single character, the integration test will now find more widgets with the text "Read me", presumably in the sidebar where FlowyText is used. Therefore, I'm changing this findOneWidget to findWidgets.
Add icons for hide and delete field
Slightly bump up the height of select option editor to make everything in the popup fit by default
Fixed padding on date and time format buttons

fixes #2761

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2791 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 6/13/2023 **Status:** ✅ Merged **Merged:** 6/16/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `ui` --- ### 📝 Commits (9) - [`40c5f78`](https://github.com/AppFlowy-IO/AppFlowy/commit/40c5f78ed822d58d2dfbfd61e81ef569a6c9467f) chore: some ui improvements - [`2ae2c72`](https://github.com/AppFlowy-IO/AppFlowy/commit/2ae2c72077ba51ce95a1e294125e7731577843b4) fix: integration test - [`1fdc3e3`](https://github.com/AppFlowy-IO/AppFlowy/commit/1fdc3e3d4ee9f429f34505caae71f93dd6971f39) feat: language selector on welcome page (#2796) - [`8c2b20d`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c2b20ded62d8c049f232937e1e88da73dab05ba) feat: row document (#2792) - [`16a5c7c`](https://github.com/AppFlowy-IO/AppFlowy/commit/16a5c7cdafe91ea9059fb8092e06ad9b00358a2c) test: fix test - [`22def51`](https://github.com/AppFlowy-IO/AppFlowy/commit/22def514d3094a854ae469ba828b05887c88999a) test: add create select option test - [`d2f7c58`](https://github.com/AppFlowy-IO/AppFlowy/commit/d2f7c58ca1681ef39f513685a74beeaa0a9dab2d) chore: Merge branch 'main' into ui - [`1499e53`](https://github.com/AppFlowy-IO/AppFlowy/commit/1499e5327ad6d483ece9ef194cbd2109693514b6) chore: Merge branch 'main' into ui - [`97ab14c`](https://github.com/AppFlowy-IO/AppFlowy/commit/97ab14c47f9f6f3f50ff1052c117f59d9b923ea7) chore: Merge branch 'main' into ui ### 📊 Changes **13 files changed** (+137 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+25 -0) 📝 `frontend/appflowy_flutter/integration_test/database_row_page_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+72 -8) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+8 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_option_editor.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart` (+4 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart` (+7 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart` (+9 -12) </details> ### 📄 Description A couple of UI improvements in the grid UI: - Remove hack for https://github.com/flutter/flutter/issues/18761 . Due to the removal of the hack that adds a zero-width space before every single character, the integration test will now find more widgets with the text "Read me", presumably in the sidebar where FlowyText is used. Therefore, I'm changing this findOneWidget to findWidgets. - Add icons for hide and delete field ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/92bdcd4e-2b64-4fa5-9d0e-4a17394d3e40) - Slightly bump up the height of select option editor to make everything in the popup fit by default - Fixed padding on date and time format buttons fixes #2761 ### Feature Preview ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>