[PR #2796] [MERGED] feat: language selector on welcome page #5426

New issue

Closed

opened 2026-03-23 22:18:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2796
Author: @hyj1204
Created: 6/14/2023
Status: ✅ Merged
Merged: 6/14/2023
Merged by: @LucasXu0

Base: main ← Head: feat/language_selector_on_welcome_page

📝 Commits (7)

186e7a3 feat: add language selector on welcome page
477cf7f feat: add hover effect and refactor layout
019acbd test: add basic languge selector testing
e357f00 chore: increate place holder width
321b3b1 fix: add catch error for setLocale and finish the testing
195c2ed chore: update comment
0595594 feat: refactor the skip login in page and add tests

📊 Changes

7 files changed (+254 additions, -48 deletions)

View changed files

➕ frontend/appflowy_flutter/assets/images/login/language.svg (+5 -0)
➕ frontend/appflowy_flutter/integration_test/language_test.dart (+45 -0)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+50 -2)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+11 -0)
📝 frontend/appflowy_flutter/lib/user/presentation/skip_log_in_screen.dart (+136 -38)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart (+3 -5)

📄 Description

Feature Preview

Close #2789

Add LanguageSelectorOnWelcomePage and its hover effect.

https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/f1565725-2300-4aef-903f-bdea2e323e17

Add test code and catch error code
While using the 'setLocale' function in 'EasyLocalization', it threw the error message 'Unable to load asset' and searched for the incorrect JSON file path. To prevent this from disrupting the process, I added some catch error code.

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2796 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 6/14/2023 **Status:** ✅ Merged **Merged:** 6/14/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/language_selector_on_welcome_page` --- ### 📝 Commits (7) - [`186e7a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/186e7a31dca9ddbafe1da5163ece6b4a96434e15) feat: add language selector on welcome page - [`477cf7f`](https://github.com/AppFlowy-IO/AppFlowy/commit/477cf7f7727844fee97abe03118033a936248d42) feat: add hover effect and refactor layout - [`019acbd`](https://github.com/AppFlowy-IO/AppFlowy/commit/019acbd2dd83447121130cbe6af2a9bd2f88495c) test: add basic languge selector testing - [`e357f00`](https://github.com/AppFlowy-IO/AppFlowy/commit/e357f004b4d3da288e576eb5a247365ba643ba9a) chore: increate place holder width - [`321b3b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/321b3b1858b828096746d71246906ba9ea198a9b) fix: add catch error for setLocale and finish the testing - [`195c2ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/195c2ede8af566e294472b5f65bd6fc34db7aaa5) chore: update comment - [`0595594`](https://github.com/AppFlowy-IO/AppFlowy/commit/05955944a386853c7a5995edd49ac8a01f7e0909) feat: refactor the skip login in page and add tests ### 📊 Changes **7 files changed** (+254 additions, -48 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/images/login/language.svg` (+5 -0) ➕ `frontend/appflowy_flutter/integration_test/language_test.dart` (+45 -0) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+50 -2) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+11 -0) 📝 `frontend/appflowy_flutter/lib/user/presentation/skip_log_in_screen.dart` (+136 -38) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart` (+3 -5) </details> ### 📄 Description   ### Feature Preview Close #2789 1. Add `LanguageSelectorOnWelcomePage` and its hover effect. https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/f1565725-2300-4aef-903f-bdea2e323e17 2. Add test code and catch error code While using the 'setLocale' function in 'EasyLocalization', it threw the error message 'Unable to load asset' and searched for the incorrect JSON file path. To prevent this from disrupting the process, I added some catch error code. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/22fe7e3a-a541-4edb-adb7-8cc0c1f28b6e)  ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>