[PR #2962] [MERGED] feat: open apps in tabs #5499

Closed
opened 2026-03-23 22:19:00 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2962
Author: @Xazin
Created: 7/10/2023
Status: Merged
Merged: 7/12/2023
Merged by: @Xazin

Base: mainHead: feat/gh-2942/tabs


📝 Commits (4)

  • 99610aa feat: open apps in tabs
  • 9b8f95e fix: resolve comments
  • 837c0e5 fix: unfocus editor to close toolbar on open/change tab
  • 23917ff test: abstract open in a new tab helper

📊 Changes

23 files changed (+653 additions, -74 deletions)

View changed files

frontend/appflowy_flutter/integration_test/tabs_test.dart (+69 -0)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+8 -0)
📝 frontend/appflowy_flutter/lib/plugins/blank/blank.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tar_bar/tab_bar_view.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/plugins/trash/menu.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/trash/trash.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+3 -4)
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart (+57 -0)
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_event.dart (+14 -0)
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_state.dart (+93 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_screen.dart (+21 -11)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart (+85 -31)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/item.dart (+14 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/section.dart (+6 -8)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/menu.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart (+6 -9)
frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart (+92 -0)

...and 3 more files

📄 Description

Closes: #2942 Relates: #2312

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/c070cf3f-5187-4ea9-84cf-5eddfe689146


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2962 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 7/10/2023 **Status:** ✅ Merged **Merged:** 7/12/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/gh-2942/tabs` --- ### 📝 Commits (4) - [`99610aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/99610aac73425779d86253de36d2dd4db9fc932a) feat: open apps in tabs - [`9b8f95e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9b8f95e8724103342745bc0008be7c4bd383b422) fix: resolve comments - [`837c0e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/837c0e54c1f3807d30dbdbc87f4ecd97c3bf4f58) fix: unfocus editor to close toolbar on open/change tab - [`23917ff`](https://github.com/AppFlowy-IO/AppFlowy/commit/23917ffafa49587b390efc833418e5eddc739f62) test: abstract open in a new tab helper ### 📊 Changes **23 files changed** (+653 additions, -74 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/tabs_test.dart` (+69 -0) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+8 -0) 📝 `frontend/appflowy_flutter/lib/plugins/blank/blank.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tar_bar/tab_bar_view.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/plugins/trash/menu.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/trash/trash.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+3 -4) ➕ `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart` (+57 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_event.dart` (+14 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_state.dart` (+93 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_screen.dart` (+21 -11) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_sizes.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart` (+85 -31) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/item.dart` (+14 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/section.dart` (+6 -8) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/menu.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart` (+6 -9) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart` (+92 -0) _...and 3 more files_ </details> ### 📄 Description Closes: #2942 Relates: #2312 <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/c070cf3f-5187-4ea9-84cf-5eddfe689146 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:00 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5499
No description provided.