[PR #3356] [MERGED] refactor: different TypeOption between DateTime and LastModified/CreatedAt #5689

New issue

Closed

opened 2026-03-23 22:19:51 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3356
Author: @richardshiue
Created: 9/7/2023
Status: ✅ Merged
Merged: 9/8/2023
Merged by: @appflowy

Base: main ← Head: date-type-option-refactor

📝 Commits (6)

0fb82ed fix: stringify date cell includes time if true
82caefb refactor: LastModified and CreatedAt type option
68a2d34 chore: frontend implementation
52b1a50 chore: some adjustments and fix tests
e19b178 fix: integration tests
b1373ae chore: timestamp type option ui

📊 Changes

42 files changed (+1254 additions, -287 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+0 -5)
📝 frontend/appflowy_flutter/integration_test/database_share_test.dart (+0 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+3 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller_builder.dart (+16 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_loader.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/date_bloc.dart (+0 -10)
➕ frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/timestamp_bloc.dart (+76 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_context.dart (+13 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/builder.dart (+18 -4)
➕ frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/timestamp.dart (+179 -0)
➕ frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/bloc/timestamp_card_cell_bloc.dart (+80 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart (+13 -2)
➕ frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/timestamp_card_cell.dart (+79 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+21 -39)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+6 -26)
➕ frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/timestamp_cell/timestamp_cell.dart (+109 -0)
➕ frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/timestamp_cell/timestamp_cell_bloc.dart (+80 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+5 -1)

...and 22 more files

📄 Description

	Date	Timestamp
Type Option	date format, time format, timezone_id	date format, time format, include_time, field_type
Cell Data PB	date string, time string, include_time, timestamp	date/time string, timestamp

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3356 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/7/2023 **Status:** ✅ Merged **Merged:** 9/8/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `date-type-option-refactor` --- ### 📝 Commits (6) - [`0fb82ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/0fb82edf31f40b29963cc4528712f223259d52d3) fix: stringify date cell includes time if true - [`82caefb`](https://github.com/AppFlowy-IO/AppFlowy/commit/82caefba9ed7fccbe50ecafb603c83366a5cc73f) refactor: LastModified and CreatedAt type option - [`68a2d34`](https://github.com/AppFlowy-IO/AppFlowy/commit/68a2d34aff6f6a74389ea6986bb740df6824044c) chore: frontend implementation - [`52b1a50`](https://github.com/AppFlowy-IO/AppFlowy/commit/52b1a50f05c2a316dcd39dcad5c3e76a4bb7f4bd) chore: some adjustments and fix tests - [`e19b178`](https://github.com/AppFlowy-IO/AppFlowy/commit/e19b178703627f7b107fe62ed605b24a26b18959) fix: integration tests - [`b1373ae`](https://github.com/AppFlowy-IO/AppFlowy/commit/b1373ae575181f9d001567528282d63ec59734b9) chore: timestamp type option ui ### 📊 Changes **42 files changed** (+1254 additions, -287 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+0 -5) 📝 `frontend/appflowy_flutter/integration_test/database_share_test.dart` (+0 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+3 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller_builder.dart` (+16 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_loader.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/date_bloc.dart` (+0 -10) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/timestamp_bloc.dart` (+76 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_context.dart` (+13 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/builder.dart` (+18 -4) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/timestamp.dart` (+179 -0) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/bloc/timestamp_card_cell_bloc.dart` (+80 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart` (+13 -2) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/timestamp_card_cell.dart` (+79 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+21 -39) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+6 -26) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/timestamp_cell/timestamp_cell.dart` (+109 -0) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/timestamp_cell/timestamp_cell_bloc.dart` (+80 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+5 -1) _...and 22 more files_ </details> ### 📄 Description | | Date | Timestamp | | :-: | :-: | :-: | | Type Option | date format, time format, timezone_id | date format, time format, include_time, field_type | | Cell Data PB | date string, time string, include_time, timestamp | date/time string, timestamp | ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>