[PR #3380] [MERGED] chore: revamp checklist ui #5704

New issue

Closed

opened 2026-03-23 22:19:55 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3380
Author: @richardshiue
Created: 9/12/2023
Status: ✅ Merged
Merged: 9/13/2023
Merged by: @appflowy

Base: main ← Head: checklist-ui-revamp

📝 Commits (5)

e27406f chore: revamp checklist editor ui
1b59357 chore: checklist progress bar
6378b08 test: integration tests
0fe8c39 fix: flutter analyzer errors
dbed7a8 fix: checklist percentage complete

📊 Changes

36 files changed (+747 additions, -394 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+112 -0)
📝 frontend/appflowy_flutter/integration_test/database_share_test.dart (+10 -10)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+138 -13)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/checklist_cell_service.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/checklist_card_cell.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart (+7 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_bloc.dart (+19 -9)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor.dart (+324 -122)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor_bloc.dart (+40 -50)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_progress_bar.dart (+25 -110)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/mask.dart (+4 -36)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+24 -11)
📝 frontend/resources/translations/ar-SA.json (+1 -1)
📝 frontend/resources/translations/ca-ES.json (+1 -1)
📝 frontend/resources/translations/de-DE.json (+1 -1)
📝 frontend/resources/translations/en.json (+3 -1)
📝 frontend/resources/translations/es-VE.json (+1 -1)
📝 frontend/resources/translations/eu-ES.json (+1 -1)
📝 frontend/resources/translations/fa.json (+1 -1)
📝 frontend/resources/translations/fr-CA.json (+1 -1)

...and 16 more files

📄 Description

An iteration on the checklist editor UI

checklist-ui.webm

A bunch of stuff are NOT included in this PR:

show tasks in grid cell or kanban/calendar card, accompanied by a setting in the type option
type option to show or hide percentage complete
cool visual effects (strikethrough, animation, etc.)
reordering checklist tasks

They'll come in a later PR. 🤞

Please not that there is also a change to the AppFlowyPopover. To intercept shortcuts in the editor, I removed the HardwareKeyboard.instance.addHandler in PopoverMask and wrapped the parent widget in a CallbackShortcuts widget. I haven't noticed regressions from my testing, but better to be sure.

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3380 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/12/2023 **Status:** ✅ Merged **Merged:** 9/13/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `checklist-ui-revamp` --- ### 📝 Commits (5) - [`e27406f`](https://github.com/AppFlowy-IO/AppFlowy/commit/e27406fa4f375169d26827aaf59fdab3eaf88113) chore: revamp checklist editor ui - [`1b59357`](https://github.com/AppFlowy-IO/AppFlowy/commit/1b59357d79ae00e876b5f9696f2477ba717aca21) chore: checklist progress bar - [`6378b08`](https://github.com/AppFlowy-IO/AppFlowy/commit/6378b08bd4ccb5dd3c3ffc29d6ea29ece3e78461) test: integration tests - [`0fe8c39`](https://github.com/AppFlowy-IO/AppFlowy/commit/0fe8c3920a34a8f71f3a1fe25331f665f9d7b3b2) fix: flutter analyzer errors - [`dbed7a8`](https://github.com/AppFlowy-IO/AppFlowy/commit/dbed7a84205613151afb42828df13f0af14fd7de) fix: checklist percentage complete ### 📊 Changes **36 files changed** (+747 additions, -394 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+112 -0) 📝 `frontend/appflowy_flutter/integration_test/database_share_test.dart` (+10 -10) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+138 -13) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/checklist_cell_service.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/checklist_card_cell.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart` (+7 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_bloc.dart` (+19 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor.dart` (+324 -122) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor_bloc.dart` (+40 -50) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_progress_bar.dart` (+25 -110) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/mask.dart` (+4 -36) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+24 -11) 📝 `frontend/resources/translations/ar-SA.json` (+1 -1) 📝 `frontend/resources/translations/ca-ES.json` (+1 -1) 📝 `frontend/resources/translations/de-DE.json` (+1 -1) 📝 `frontend/resources/translations/en.json` (+3 -1) 📝 `frontend/resources/translations/es-VE.json` (+1 -1) 📝 `frontend/resources/translations/eu-ES.json` (+1 -1) 📝 `frontend/resources/translations/fa.json` (+1 -1) 📝 `frontend/resources/translations/fr-CA.json` (+1 -1) _...and 16 more files_ </details> ### 📄 Description An iteration on the checklist editor UI [checklist-ui.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/95540999-4ad4-49c8-bcd8-525e60b40f2b) A bunch of stuff are NOT included in this PR: - show tasks in grid cell or kanban/calendar card, accompanied by a setting in the type option - type option to show or hide percentage complete - cool visual effects (strikethrough, animation, etc.) - reordering checklist tasks They'll come in a later PR. 🤞 Please not that there is also a change to the AppFlowyPopover. To intercept shortcuts in the editor, I removed the `HardwareKeyboard.instance.addHandler` in `PopoverMask` and wrapped the parent widget in a `CallbackShortcuts` widget. I haven't noticed regressions from my testing, but better to be sure. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>