[PR #3487] [MERGED] feat: enable removing user icon #5739

New issue

Closed

opened 2026-03-23 22:20:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3487
Author: @Xazin
Created: 9/21/2023
Status: ✅ Merged
Merged: 9/22/2023
Merged by: @Xazin

Base: main ← Head: feat/remove-user-icon

📝 Commits (5)

b1c7d4a feat: enable removing user icon
077a40a fix: generate to true
762b339 fix: review comments
ba6f628 fix: more review comments
4b210ed fix: integration test and final changes

📊 Changes

30 files changed (+392 additions, -178 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/settings/user_icon_test.dart (+54 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/user/settings_user_bloc.dart (+11 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_user.dart (+5 -48)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_user_view.dart (+208 -104)
➕ frontend/appflowy_flutter/lib/workspace/presentation/widgets/flowy_tooltip.dart (+20 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/widgets/user_avatar.dart (+82 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart (+9 -0)
📝 frontend/resources/translations/ar-SA.json (+0 -1)
📝 frontend/resources/translations/ca-ES.json (+0 -1)
📝 frontend/resources/translations/de-DE.json (+0 -1)
📝 frontend/resources/translations/en.json (+1 -1)
📝 frontend/resources/translations/es-VE.json (+0 -1)
📝 frontend/resources/translations/eu-ES.json (+0 -1)
📝 frontend/resources/translations/fa.json (+0 -1)
📝 frontend/resources/translations/fr-CA.json (+0 -1)
📝 frontend/resources/translations/fr-FR.json (+0 -1)
📝 frontend/resources/translations/hu-HU.json (+0 -1)
📝 frontend/resources/translations/id-ID.json (+0 -1)
📝 frontend/resources/translations/it-IT.json (+1 -2)
📝 frontend/resources/translations/ja-JP.json (+0 -1)

...and 10 more files

📄 Description

Closes: #2928

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/7d626b89-80ca-4b57-92d5-7449b5cb482f

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3487 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 9/21/2023 **Status:** ✅ Merged **Merged:** 9/22/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/remove-user-icon` --- ### 📝 Commits (5) - [`b1c7d4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/b1c7d4a70fb6a2cd40377b7765f6086ecdbf5b7b) feat: enable removing user icon - [`077a40a`](https://github.com/AppFlowy-IO/AppFlowy/commit/077a40a291ac51bd84d753ec360e9a1453f15d4a) fix: generate to true - [`762b339`](https://github.com/AppFlowy-IO/AppFlowy/commit/762b3392df87f4570d784b066628a84c96724429) fix: review comments - [`ba6f628`](https://github.com/AppFlowy-IO/AppFlowy/commit/ba6f6282a406ecda850944900ce59af66083959a) fix: more review comments - [`4b210ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/4b210eda4fbdc3661db8d1e762be2795a6ff0af8) fix: integration test and final changes ### 📊 Changes **30 files changed** (+392 additions, -178 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/settings/user_icon_test.dart` (+54 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/user/settings_user_bloc.dart` (+11 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_user.dart` (+5 -48) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_user_view.dart` (+208 -104) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/flowy_tooltip.dart` (+20 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/user_avatar.dart` (+82 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart` (+9 -0) 📝 `frontend/resources/translations/ar-SA.json` (+0 -1) 📝 `frontend/resources/translations/ca-ES.json` (+0 -1) 📝 `frontend/resources/translations/de-DE.json` (+0 -1) 📝 `frontend/resources/translations/en.json` (+1 -1) 📝 `frontend/resources/translations/es-VE.json` (+0 -1) 📝 `frontend/resources/translations/eu-ES.json` (+0 -1) 📝 `frontend/resources/translations/fa.json` (+0 -1) 📝 `frontend/resources/translations/fr-CA.json` (+0 -1) 📝 `frontend/resources/translations/fr-FR.json` (+0 -1) 📝 `frontend/resources/translations/hu-HU.json` (+0 -1) 📝 `frontend/resources/translations/id-ID.json` (+0 -1) 📝 `frontend/resources/translations/it-IT.json` (+1 -2) 📝 `frontend/resources/translations/ja-JP.json` (+0 -1) _...and 10 more files_ </details> ### 📄 Description Closes: #2928 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/7d626b89-80ca-4b57-92d5-7449b5cb482f #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>