[PR #3500] [MERGED] Fix 032 launch review issues #5743

New issue

Closed

opened 2026-03-23 22:20:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3500
Author: @LucasXu0
Created: 9/22/2023
Status: ✅ Merged
Merged: 9/23/2023
Merged by: @LucasXu0

Base: main ← Head: fix_032_launch_review_issues

📝 Commits (5)

5dfc470 chore: add more space between font item and font menu
57b78ee feat: add reset font button in toolbar
f762a56 feat: only show text direction toolbar item when RTL is enabled
f2f3506 fix: unable to change RTL of heading block
89face4 test: add integration test for ltr/rtl mode

📊 Changes

11 files changed (+179 additions, -12 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_test_runner.dart (+2 -0)
➕ frontend/appflowy_flutter/integration_test/document/document_text_direction_test.dart (+58 -0)
📝 frontend/appflowy_flutter/integration_test/util/settings.dart (+33 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+22 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/font/customize_font_toolbar_item.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+47 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/theme_setting_entry_template.dart (+4 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+3 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/resources/translations/en.json (+3 -0)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/3499

Add padding and reset to default button

keep the previous font family

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/a9690876-474b-4f03-afe6-e381fe12315b

only show the text direction items on RTL mode

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3500 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/22/2023 **Status:** ✅ Merged **Merged:** 9/23/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_032_launch_review_issues` --- ### 📝 Commits (5) - [`5dfc470`](https://github.com/AppFlowy-IO/AppFlowy/commit/5dfc4708732a2e04548a138c94687983f4c58ac8) chore: add more space between font item and font menu - [`57b78ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/57b78ee3c61ca3151dd03ed07868c974fe5a64bb) feat: add reset font button in toolbar - [`f762a56`](https://github.com/AppFlowy-IO/AppFlowy/commit/f762a564b5a91276d8a666383390ff2dc4c21105) feat: only show text direction toolbar item when RTL is enabled - [`f2f3506`](https://github.com/AppFlowy-IO/AppFlowy/commit/f2f3506b29dcd58437e5ff4548d72d29cf933fa5) fix: unable to change RTL of heading block - [`89face4`](https://github.com/AppFlowy-IO/AppFlowy/commit/89face4f02b3f309bd78497809294d7170173c25) test: add integration test for ltr/rtl mode ### 📊 Changes **11 files changed** (+179 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_test_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_text_direction_test.dart` (+58 -0) 📝 `frontend/appflowy_flutter/integration_test/util/settings.dart` (+33 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+22 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/font/customize_font_toolbar_item.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+47 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/theme_setting_entry_template.dart` (+4 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+3 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/resources/translations/en.json` (+3 -0) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/3499 #### Add padding and reset to default button <img width="272" alt="Screenshot 2023-09-22 at 16 03 34" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/80e436a7-9e67-4bdb-940d-1a90d1e9e6d7"> #### keep the previous font family https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/a9690876-474b-4f03-afe6-e381fe12315b #### only show the text direction items on RTL mode <img width="749" alt="Screenshot 2023-09-22 at 15 50 51" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/34b3e9a0-5fa0-4380-8aef-1465b5593c51"> <img width="749" alt="Screenshot 2023-09-22 at 15 50 51" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/46cda247-2156-4189-be4f-3c69295226cd">  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>