[PR #3553] [MERGED] refactor: ui improvement in appearance #5763

New issue

Closed

opened 2026-03-23 22:20:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3553
Author: @MayurSMahajan
Created: 9/28/2023
Status: ✅ Merged
Merged: 10/5/2023
Merged by: @LucasXu0

Base: main ← Head: ui_improvement_in_appearance

📝 Commits (7)

49027c4 chore: add divider to all options
33c3148 refactor: remove unused context
fd172a5 Merge remote-tracking branch 'upstream/main' into ui_improvement_in_appearance
189c95b fix: add space above sync setting
511d73c fix: use final for variable
b4a20ee Merge remote-tracking branch 'upstream/main' into ui_improvement_in_appearance
b18f047 refactor: use FlowyTooltip instead

📊 Changes

4 files changed (+52 additions, -35 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart (+27 -26)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+15 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+8 -4)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart (+2 -0)

📄 Description

The PR achieves the following:

Adds dividers to every option in Appearance Settings
Moves the Tooltip closer to the ThemeMode button
Tooltip text now says Change Theme Mode, which is a descriptive action rather than plain Theme Mode
Removes unused context parameter from the tooltipMethod.

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3553 **Author:** [@MayurSMahajan](https://github.com/MayurSMahajan) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 10/5/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `ui_improvement_in_appearance` --- ### 📝 Commits (7) - [`49027c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/49027c4f3acc4287d2970dc5eb2b7f4bbfe4e005) chore: add divider to all options - [`33c3148`](https://github.com/AppFlowy-IO/AppFlowy/commit/33c31484a833d8f91d209da621e0d1f691704000) refactor: remove unused context - [`fd172a5`](https://github.com/AppFlowy-IO/AppFlowy/commit/fd172a5e9932c18cdb7d116f51907d5eb0834152) Merge remote-tracking branch 'upstream/main' into ui_improvement_in_appearance - [`189c95b`](https://github.com/AppFlowy-IO/AppFlowy/commit/189c95b27fbc1d75b42a8bc43cb22886015d9b34) fix: add space above sync setting - [`511d73c`](https://github.com/AppFlowy-IO/AppFlowy/commit/511d73cdc1e281229166b92bd80dff439e2a3a4c) fix: use final for variable - [`b4a20ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4a20ee44d9ea76e582f1e79d67ed27b94a70f91) Merge remote-tracking branch 'upstream/main' into ui_improvement_in_appearance - [`b18f047`](https://github.com/AppFlowy-IO/AppFlowy/commit/b18f047775acdd3043bb3727ba46e0c9b520bfc5) refactor: use FlowyTooltip instead ### 📊 Changes **4 files changed** (+52 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart` (+27 -26) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+15 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+8 -4) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart` (+2 -0) </details> ### 📄 Description  The PR achieves the following: - Adds dividers to every option in Appearance Settings - Moves the Tooltip closer to the ThemeMode button - Tooltip text now says Change Theme Mode, which is a descriptive action rather than plain Theme Mode - Removes unused context parameter from the tooltipMethod.  ### Feature Preview ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/5141c82b-d16f-4835-8486-997a13622f1b)  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>