[PR #3686] [MERGED] fix: fix lemonade theme issues #5828

New issue

Closed

opened 2026-03-23 22:20:29 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3686
Author: @hyj1204
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/15/2023
Merged by: @LucasXu0

Base: main ← Head: fix/lemonade

📝 Commits (3)

5dfefe6 chore: make shadow color lighter
cc37e56 fix: share button color contrast
636d65a chore: unify selector color in dark mode

📊 Changes

5 files changed (+6 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/share_button.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart (+1 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lemonade.dart (+2 -2)

📄 Description

Share button color improvement: I found a dark text color actually matches all the theme's primary color

Improve the shadow color in light mode.
Use the same hover color in dark mode for any theme:

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3686 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/15/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/lemonade` --- ### 📝 Commits (3) - [`5dfefe6`](https://github.com/AppFlowy-IO/AppFlowy/commit/5dfefe6010d3342bdad64c1243cdfa331a6c19b6) chore: make shadow color lighter - [`cc37e56`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc37e56684f762a4fb60bd1f8a9f564cb9f6ea5c) fix: share button color contrast - [`636d65a`](https://github.com/AppFlowy-IO/AppFlowy/commit/636d65a058a1983704bf45a45ac95c621e9a9a3b) chore: unify selector color in dark mode ### 📊 Changes **5 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/share_button.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart` (+1 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lemonade.dart` (+2 -2) </details> ### 📄 Description  - Share button color improvement: I found a dark text color actually matches all the theme's primary color <img width="147" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/a45df0dc-a3a5-49d2-9270-cde574e6c0d1"> <img width="140" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/8ae6af4c-2dca-4f32-8598-08406e258162"> <img width="138" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/10389e03-83b6-4fd4-873d-179f9102635f"> <img width="130" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/b7550ddb-5fd6-4979-816b-0badc944dd79"> <img width="137" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/7a5b6cbe-0eb9-4240-bf57-ca85c6cb803f"> <img width="144" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/4d4cbbd1-9700-4e84-90e8-8130cae80ea2"> - Improve the shadow color in light mode. <img width="190" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/03c09f4c-9e9b-4c65-bba7-7c1be52c0f31"> - Use the same hover color in dark mode for any theme: <img width="168" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/994996ba-d1fa-4fcb-8d54-633de9f2d6a7">  ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>