mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 04:46:56 +00:00
[PR #3891] [CLOSED] build: added the option to use static libraries #5930
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#5930
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3891
Author: @zoli
Created: 11/6/2023
Status: ❌ Closed
Base:
main← Head:build/reduce-build-time📝 Commits (10+)
bd76bbcbuild: introducing USE_STATIC_LIB env45b9f1afix: install git before jemalloc41c882a0fix: jemalloc4 rocksdb conflict8c28c6fbuild: test running cargo make in 3 ways5660c02fix: dockerfile workdir53d35defix: source cargo for everey runb9fcf1dfix: use curl instead of wgetc2b0da4fix: install wget8b30c33fix: change dockerfile back to build productionf7e25acfix: enable USE_STATIC only on linux for now📊 Changes
9 files changed (+75 additions, -60 deletions)
View changed files
📝
.github/workflows/flutter_ci.yaml(+7 -1)📝
.github/workflows/mobile_ci.yaml(+3 -3)📝
.github/workflows/rust_ci.yaml(+7 -7)📝
.github/workflows/rust_coverage.yml(+5 -6)📝
.github/workflows/tauri_ci.yaml(+5 -4)📝
.gitignore(+3 -0)📝
frontend/scripts/docker-buildfiles/Dockerfile(+9 -8)📝
frontend/scripts/makefile/desktop.toml(+35 -30)📝
frontend/scripts/makefile/flutter.toml(+1 -1)📄 Description
Feature Preview
Added
USET_STATIC_LIBenvironment variable to build AppFlowy SDK (sdk-dev-buildtask) using openssl, zstd, rocksdb static libraries, and eliminating their compile time.I got static libraries from "rust-lib/target" directory (e.g. "frontend/rust-lib/target/x86_64-unknown-linux-gnu/debug/build/zstd-sys-2ceef7f8e16ac49d/out/" for zstd) which were built with
cargo make --profile development-linux-x86_64 appflowy-core-devcommand. I created a compressed file from all of them. The compressed file should get generated for each platform separately.The result on my laptop was about 10-13 minutes saving build time for
appflowy-core-devtask afterflutter_cleantask (the download time of the static libraries was not included).Had some related notes and discussions before here https://github.com/AppFlowy-IO/AppFlowy/pull/3519.
PR Checklist
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.