[PR #4382] [MERGED] feat: toggle favourites from the documents top bar. #6228

Closed
opened 2026-03-23 22:22:17 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4382
Author: @AnsahMohammad
Created: 1/13/2024
Status: Merged
Merged: 2/8/2024
Merged by: @Xazin

Base: mainHead: star_button


📝 Commits (10+)

  • 3da7cea feat: init star button
  • 7751b74 feat: implemented star button on the right bar
  • 45eb9d1 feat: Implemented toggle logic
  • a85a744 chore: Added ToolTip for favorite button
  • 25f42df refactor: renamed star to favorite
  • 74c6ff8 refactor: moved appplication logic into favorite_cubit
  • a012302 chore: arranged imports in alphabetical order
  • 0c28616 refactor: reused favorite_bloc for toggle
  • e5e5272 fix: fixed the icon no rebuild
  • 7c74b20 refactor: moved the FavoriteBloc higher in the widget tree

📊 Changes

4 files changed (+65 additions, -3 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+6 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/favorite/favorite_button.dart (+54 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+0 -3)

📄 Description

Feature Preview

Add a favorite icon in the top bar of the document to easily toggle the document as favourite or not:

image

Impact :

  • Easier for all the user to toggle the favourite

PR Checklist

this PR closes #4383

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4382 **Author:** [@AnsahMohammad](https://github.com/AnsahMohammad) **Created:** 1/13/2024 **Status:** ✅ Merged **Merged:** 2/8/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `star_button` --- ### 📝 Commits (10+) - [`3da7cea`](https://github.com/AppFlowy-IO/AppFlowy/commit/3da7cea0d1c6e8f32c07716cfbf3b5a2d000e63a) feat: init star button - [`7751b74`](https://github.com/AppFlowy-IO/AppFlowy/commit/7751b74825cf40630c23ac7f60c43b6d1f5fcbca) feat: implemented star button on the right bar - [`45eb9d1`](https://github.com/AppFlowy-IO/AppFlowy/commit/45eb9d157242a2f985ffa048652cd48c59db6d26) feat: Implemented toggle logic - [`a85a744`](https://github.com/AppFlowy-IO/AppFlowy/commit/a85a7446dd556f31ef41cae7eab59033f8081574) chore: Added ToolTip for favorite button - [`25f42df`](https://github.com/AppFlowy-IO/AppFlowy/commit/25f42dfbca3547b568f017bed44cd78a1c18160d) refactor: renamed star to favorite - [`74c6ff8`](https://github.com/AppFlowy-IO/AppFlowy/commit/74c6ff82cf266d303004ba442a0179c63cca025b) refactor: moved appplication logic into favorite_cubit - [`a012302`](https://github.com/AppFlowy-IO/AppFlowy/commit/a012302f6d7c5a0ffcde08e100d7e68160c891b5) chore: arranged imports in alphabetical order - [`0c28616`](https://github.com/AppFlowy-IO/AppFlowy/commit/0c28616551a9fa08f465d32ee75776d7bed30162) refactor: reused favorite_bloc for toggle - [`e5e5272`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5e52726398a4af652d810639f2ccbdb7c7777c5) fix: fixed the icon no rebuild - [`7c74b20`](https://github.com/AppFlowy-IO/AppFlowy/commit/7c74b20933d1c46d6ac7c187f73906f55a968329) refactor: moved the FavoriteBloc higher in the widget tree ### 📊 Changes **4 files changed** (+65 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+6 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/favorite/favorite_button.dart` (+54 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+0 -3) </details> ### 📄 Description ### Feature Preview Add a favorite icon in the top bar of the document to easily toggle the document as favourite or not: ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/85027826/6ae3db52-a217-4a79-8173-8033be4a5a6c) Impact : - Easier for all the user to toggle the favourite #### PR Checklist this PR closes #4383 - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6228
No description provided.