[PR #6228] [MERGED] fix(flutter_desktop): incorrect colors for switch workspace button #7260

Closed
opened 2026-03-23 23:18:49 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6228
Author: @richardshiue
Created: 9/7/2024
Status: Merged
Merged: 9/9/2024
Merged by: @LucasXu0

Base: mainHead: fix/switch-workspace-ui


📝 Commits (2)

  • c7e0d6d fix: incorrect colors for switch workspace button
  • fca0f31 chore: apply code style suggestions

📊 Changes

5 files changed (+86 additions, -34 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+62 -28)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/workspace_member_bloc.dart (+5 -1)
📝 frontend/appflowy_flutter/macos/Podfile.lock (+1 -1)

📄 Description

Before:

Theme Light Dark
Default Screenshot 2024-09-07 at 6 03 28 PM Screenshot 2024-09-07 at 6 03 39 PM
Dandelion Screenshot 2024-09-07 at 6 04 12 PM Screenshot 2024-09-07 at 6 03 56 PM

After:

Theme Light Dark
Default Screenshot 2024-09-07 at 6 02 25 PM Screenshot 2024-09-07 at 6 01 25 PM
Dandelion Screenshot 2024-09-07 at 5 58 30 PM Screenshot 2024-09-07 at 5 58 47 PM

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6228 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/7/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/switch-workspace-ui` --- ### 📝 Commits (2) - [`c7e0d6d`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7e0d6d8ba5559164080e60245cf888ddf3f4966) fix: incorrect colors for switch workspace button - [`fca0f31`](https://github.com/AppFlowy-IO/AppFlowy/commit/fca0f316f68450833aa614f6b0ba81e2d2956439) chore: apply code style suggestions ### 📊 Changes **5 files changed** (+86 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+62 -28) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/workspace_member_bloc.dart` (+5 -1) 📝 `frontend/appflowy_flutter/macos/Podfile.lock` (+1 -1) </details> ### 📄 Description Before: |Theme|Light|Dark |---|---|---| | Default | ![Screenshot 2024-09-07 at 6 03 28 PM](https://github.com/user-attachments/assets/acde5602-8655-4a67-8d98-055a374ded1e) | ![Screenshot 2024-09-07 at 6 03 39 PM](https://github.com/user-attachments/assets/f01fd1ec-8264-441c-9be0-b687f670771a) | | Dandelion | ![Screenshot 2024-09-07 at 6 04 12 PM](https://github.com/user-attachments/assets/6cc0b0ce-44f5-4060-a3d4-0f5ff2b30bcd) | ![Screenshot 2024-09-07 at 6 03 56 PM](https://github.com/user-attachments/assets/4d603770-60ff-48ed-b5b8-8b91ef3f9b53) | After: |Theme|Light|Dark| |---|---|---| |Default| ![Screenshot 2024-09-07 at 6 02 25 PM](https://github.com/user-attachments/assets/0c6f1eeb-532e-419b-bb46-c05ec22cb848) | ![Screenshot 2024-09-07 at 6 01 25 PM](https://github.com/user-attachments/assets/1839d0ad-18b1-43ae-ad5f-3ca5c0110aa4) | |Dandelion| ![Screenshot 2024-09-07 at 5 58 30 PM](https://github.com/user-attachments/assets/cac909b1-40d7-4cda-9cb3-aff265550a77) | ![Screenshot 2024-09-07 at 5 58 47 PM](https://github.com/user-attachments/assets/345016e0-e53b-4e4a-9bb3-718daa203af9) | ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:18:49 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7260
No description provided.