[PR #4611] [MERGED] fix: deleting a sorting field doesn't delete existing sorts #6345

New issue

Closed

opened 2026-03-23 22:22:49 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4611
Author: @richardshiue
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @richardshiue

Base: main ← Head: fix/sort-avada-kedavra

📝 Commits (1)

593b550 fix: deleting a sorting field doesn't delete existing sorts

📊 Changes

2 files changed (+34 additions, -27 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+29 -14)
📝 frontend/rust-lib/flowy-database2/src/services/sort/entities.rs (+5 -13)

📄 Description

resovles #4520

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4611 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/sort-avada-kedavra` --- ### 📝 Commits (1) - [`593b550`](https://github.com/AppFlowy-IO/AppFlowy/commit/593b550c2239c675ad0f52321a245cbd7598ddcd) fix: deleting a sorting field doesn't delete existing sorts ### 📊 Changes **2 files changed** (+34 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+29 -14) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/entities.rs` (+5 -13) </details> ### 📄 Description resovles #4520  ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>