[PR #6345] [MERGED] fix: icon doesn't align to the editor if the editor is not initialized #7324

New issue

Closed

opened 2026-03-23 23:19:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6345
Author: @LucasXu0
Created: 9/18/2024
Status: ✅ Merged
Merged: 9/19/2024
Merged by: @LucasXu0

Base: main ← Head: fix_icon_align

📝 Commits (1)

d074818 fix: icon doesn't align with the editor when the editor is not initialized

📊 Changes

1 file changed (+15 additions, -3 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+15 -3)

📄 Description

Feature Preview

In some cases, when the editor initialization is not finished, retrieving the offset returns 0 always.

before
Screenshot 2024-09-18 at 20 15 10
after
Screenshot 2024-09-18 at 20 27 27

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6345 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/18/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_icon_align` --- ### 📝 Commits (1) - [`d074818`](https://github.com/AppFlowy-IO/AppFlowy/commit/d0748181316dfdf53f6f709180a4f543b19c27cc) fix: icon doesn't align with the editor when the editor is not initialized ### 📊 Changes **1 file changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+15 -3) </details> ### 📄 Description   ### Feature Preview In some cases, when the editor initialization is not finished, retrieving the offset returns 0 always. before <img width="1535" alt="Screenshot 2024-09-18 at 20 15 10" src="https://github.com/user-attachments/assets/d9ebeb61-80d1-48d2-8e90-b72ad383b7e2"> after <img width="1535" alt="Screenshot 2024-09-18 at 20 27 27" src="https://github.com/user-attachments/assets/37dbd0e1-6e10-48e5-a1b3-afef9b7adf8b">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>