[PR #4625] [MERGED] fix: dispose of resources in time #6352

New issue

Closed

opened 2026-03-23 22:22:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4625
Author: @Xazin
Created: 2/7/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @Xazin

Base: main ← Head: fix/disposal-cleanup

📝 Commits (8)

d30fe4a fix: limit length when renaming views
3800238 chore: clean up database listeners
628b69b fix: dispose of controllers properly
4fbc02a fix: dispose of resources properly
02b31db fix: deleting filters with same name
648f847 chore: extend DatabaseTabBarItemBuilder
ecdf877 fix: null check on null value
7015ca0 chore: merge branch 'upstream/main' into fix/disposal-cleanup

📊 Changes

61 files changed (+383 additions, -334 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_rename_widget.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_board_trailing.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/edit_username_bottom_sheet.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checkbox_cell_bloc.dart (+10 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_bloc.dart (+10 -9)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/number_cell_bloc.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_cell_bloc.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/text_cell_bloc.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/timestamp_cell_bloc.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/url_cell_bloc.dart (+10 -10)
➖ frontend/appflowy_flutter/lib/plugins/database/application/layout/layout_listener.dart (+0 -52)
➖ frontend/appflowy_flutter/lib/plugins/database/application/setting/setting_controller.dart (+0 -62)
📝 frontend/appflowy_flutter/lib/plugins/database/application/tab_bar_bloc.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_setting_bloc.dart (+6 -6)

...and 41 more files

📄 Description

This PR aims to dispose of resources when possible, and fix some miscelleanous issues.

Closes: #2611

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4625 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 2/7/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/disposal-cleanup` --- ### 📝 Commits (8) - [`d30fe4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/d30fe4acbd7dd21bd62a42eae28edc7c78066c1f) fix: limit length when renaming views - [`3800238`](https://github.com/AppFlowy-IO/AppFlowy/commit/3800238a2e7fc8b34e2976f8c16c85845962fad2) chore: clean up database listeners - [`628b69b`](https://github.com/AppFlowy-IO/AppFlowy/commit/628b69b4b6122a4f8a849abe52ec703fa3e7cc34) fix: dispose of controllers properly - [`4fbc02a`](https://github.com/AppFlowy-IO/AppFlowy/commit/4fbc02ad5cbb98780217151bc129698f9a9b90b5) fix: dispose of resources properly - [`02b31db`](https://github.com/AppFlowy-IO/AppFlowy/commit/02b31db66dbde27db71270cd0ed70260d11d1471) fix: deleting filters with same name - [`648f847`](https://github.com/AppFlowy-IO/AppFlowy/commit/648f8470a3fa04ad0cfe0c5ef18e25646319e99c) chore: extend DatabaseTabBarItemBuilder - [`ecdf877`](https://github.com/AppFlowy-IO/AppFlowy/commit/ecdf877959c2adfac62fbec035a2d994def2577f) fix: null check on null value - [`7015ca0`](https://github.com/AppFlowy-IO/AppFlowy/commit/7015ca04dc356ca1510c44e4d4619b32900c4f91) chore: merge branch 'upstream/main' into fix/disposal-cleanup ### 📊 Changes **61 files changed** (+383 additions, -334 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_rename_widget.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_board_trailing.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/edit_username_bottom_sheet.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checkbox_cell_bloc.dart` (+10 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_bloc.dart` (+10 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/number_cell_bloc.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_cell_bloc.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/text_cell_bloc.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/timestamp_cell_bloc.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/url_cell_bloc.dart` (+10 -10) ➖ `frontend/appflowy_flutter/lib/plugins/database/application/layout/layout_listener.dart` (+0 -52) ➖ `frontend/appflowy_flutter/lib/plugins/database/application/setting/setting_controller.dart` (+0 -62) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/tab_bar_bloc.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_setting_bloc.dart` (+6 -6) _...and 41 more files_ </details> ### 📄 Description This PR aims to dispose of resources when possible, and fix some miscelleanous issues. Closes: #2611 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>