[PR #6352] [MERGED] fix: hide line numbers in code block #7326

New issue

Closed

opened 2026-03-23 23:19:07 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6352
Author: @Xazin
Created: 9/18/2024
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @appflowy

Base: main ← Head: fix/hide-line-numbers

📝 Commits (1)

70e064c fix: hide line numbers in code block

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+4 -2)

📄 Description

I haven't been able to reproduce the issues with line numbers shifting vertically compared to the lines. Right now the way we have built the Code Block using the Markdown makes the layout of the line numbers reliant on having the same font size and line height as the text to the right of it, I'm assuming the issue might be related to accessibility or something else that shifts the font size.

This PR simply hides line numbers in a code block.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6352 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 9/18/2024 **Status:** ✅ Merged **Merged:** 9/21/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/hide-line-numbers` --- ### 📝 Commits (1) - [`70e064c`](https://github.com/AppFlowy-IO/AppFlowy/commit/70e064c552897729fd11564d573fb52c4bb20028) fix: hide line numbers in code block ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+4 -2) </details> ### 📄 Description I haven't been able to reproduce the issues with line numbers shifting vertically compared to the lines. Right now the way we have built the Code Block using the Markdown makes the layout of the line numbers reliant on having the same font size and line height as the text to the right of it, I'm assuming the issue might be related to accessibility or something else that shifts the font size. This PR simply hides line numbers in a code block. ### Feature Preview ![Screenshot 2024-09-18 at 23 55 03](https://github.com/user-attachments/assets/4a22762b-5e57-4798-9954-5cbab7b6ddef) #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>