[PR #4801] [MERGED] fix: stop hover when scrolling #6451

New issue

Closed

opened 2026-03-23 22:23:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4801
Author: @Xazin
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @Xazin

Base: main ← Head: fix/stop-hover-when-scrolling

📝 Commits (2)

48a52a2 fix: stop hover when scrolling
d95b03f chore: merge branch 'upstream/main' into fix/stop-hover-when-scrolling

📊 Changes

4 files changed (+83 additions, -14 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+55 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_folder.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+17 -4)

📄 Description

Closes: #4695

I'm not sure this is what we want, it feels a bit hacky. I do understand that this is how some applications work, but still.

I also added clamping scroll physics to stop an odd UI behavior when scrolling out of bounds.

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/e96eb20f-2f0e-446d-b83d-3cf4b36ef1c2

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4801 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/stop-hover-when-scrolling` --- ### 📝 Commits (2) - [`48a52a2`](https://github.com/AppFlowy-IO/AppFlowy/commit/48a52a253ac03fe53b4f5328a7431c1dd823b31f) fix: stop hover when scrolling - [`d95b03f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d95b03f5e6f300d59b21b57129e3d971b428f891) chore: merge branch 'upstream/main' into fix/stop-hover-when-scrolling ### 📊 Changes **4 files changed** (+83 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+55 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_folder.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+17 -4) </details> ### 📄 Description Closes: #4695 I'm not sure this is what we want, it feels a bit hacky. I do understand that this is how some applications work, but still. I also added clamping scroll physics to stop an odd UI behavior when scrolling out of bounds. ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/e96eb20f-2f0e-446d-b83d-3cf4b36ef1c2 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>