[PR #6451] [MERGED] fix: field type option transform #7388

New issue

Closed

opened 2026-03-23 23:19:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6451
Author: @richardshiue
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @richardshiue

Base: main ← Head: fix/switch-field-type

📝 Commits (4)

6994fbf test: add field transform tests
22528c7 fix: type option transform messing up type option data
790371f test: add date time transform integration test
2320239 fix: update view editor

📊 Changes

8 files changed (+268 additions, -93 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart (+13 -13)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart (+185 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_share_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+6 -6)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+0 -17)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+38 -37)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+14 -13)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/type_option_transform.rs (+11 -4)

📄 Description

Before

https://github.com/user-attachments/assets/5d50e8de-c813-4469-9b12-8bffb3b6549f

After

https://github.com/user-attachments/assets/a2972ef3-4fd7-4571-b9c0-1b5b97176afa

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6451 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/switch-field-type` --- ### 📝 Commits (4) - [`6994fbf`](https://github.com/AppFlowy-IO/AppFlowy/commit/6994fbf4f7f1b59e36b5782c31e1c28e4061b662) test: add field transform tests - [`22528c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/22528c74155c8fcf6175d545f3eded9d67ca096b) fix: type option transform messing up type option data - [`790371f`](https://github.com/AppFlowy-IO/AppFlowy/commit/790371f1e6709730aee37b5f430be64c1f463d57) test: add date time transform integration test - [`2320239`](https://github.com/AppFlowy-IO/AppFlowy/commit/2320239fb6e13719e3a4ed89f283ba5b985bf555) fix: update view editor ### 📊 Changes **8 files changed** (+268 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart` (+13 -13) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart` (+185 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_share_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+6 -6) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+0 -17) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+38 -37) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+14 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/type_option_transform.rs` (+11 -4) </details> ### 📄 Description Before https://github.com/user-attachments/assets/5d50e8de-c813-4469-9b12-8bffb3b6549f After https://github.com/user-attachments/assets/a2972ef3-4fd7-4571-b9c0-1b5b97176afa ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>