[PR #4880] [MERGED] refactor: group controller traits #6512

New issue

Closed

opened 2026-03-23 22:23:33 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4880
Author: @richardshiue
Created: 3/12/2024
Status: ✅ Merged
Merged: 3/16/2024
Merged by: @richardshiue

Base: main ← Head: feat/group-filters

📝 Commits (10+)

64d8389 chore: remove async trait
74734bf chore: require From for trait TypeOption
32b6ecc refactor: simplify group controller by removing GroupController trait
968f6a3 chore: rename GroupControllerOperation trait to GroupController
6e19a39 chore: add some docs
2730a7a chore: remove plural struct and use Vec directly
97f43ac chore: unnecessary mut
087a019 chore: use same name to indicate passthrough
9db077e chore: remove unused trait
84d7987 chore: rename group context to group controller context

📊 Changes

32 files changed (+479 additions, -951 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart (+70 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/board/application/group_controller.dart (+3 -15)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart (+2 -2)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/group_by_multi_select_field_test.dart (+0 -12)
📝 frontend/appflowy_tauri/src/appflowy_app/application/database/group/group_types.ts (+0 -2)
📝 frontend/rust-lib/event-integration/tests/database/local_test/group_test.rs (+0 -14)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs (+0 -4)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group_changeset.rs (+4 -18)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+6 -2)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+19 -26)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs (+22 -60)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/views.rs (+0 -27)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs (+5 -20)
📝 frontend/rust-lib/flowy-database2/src/services/group/action.rs (+32 -18)
📝 frontend/rust-lib/flowy-database2/src/services/group/configuration.rs (+36 -106)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller.rs (+57 -74)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/checkbox_controller.rs (+13 -44)

...and 12 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4880 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 3/12/2024 **Status:** ✅ Merged **Merged:** 3/16/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/group-filters` --- ### 📝 Commits (10+) - [`64d8389`](https://github.com/AppFlowy-IO/AppFlowy/commit/64d8389432ef92b46bbcf75fffa89f2d06b6b896) chore: remove async trait - [`74734bf`](https://github.com/AppFlowy-IO/AppFlowy/commit/74734bf8110544c6b16973e2f0978643e95e2e95) chore: require From<AnyMap> for trait TypeOption - [`32b6ecc`](https://github.com/AppFlowy-IO/AppFlowy/commit/32b6ecca9e6b9a48bd570276dbb06796d86cc470) refactor: simplify group controller by removing GroupController trait - [`968f6a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/968f6a38570daf31e56657fd7583fc1ff1b7c8d0) chore: rename GroupControllerOperation trait to GroupController - [`6e19a39`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e19a39d3db2c67e2f753081f2ed01556173f2b5) chore: add some docs - [`2730a7a`](https://github.com/AppFlowy-IO/AppFlowy/commit/2730a7acde65570d0067ef327a8c3a48e198da3e) chore: remove plural struct and use Vec directly - [`97f43ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/97f43ace7e635b728ffe3fad82aaec06067da19c) chore: unnecessary mut - [`087a019`](https://github.com/AppFlowy-IO/AppFlowy/commit/087a019c9f9ab2078f3aa53e26917953d90884d5) chore: use same name to indicate passthrough - [`9db077e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9db077ecc6476d62bd524f94c3fbce21fda16616) chore: remove unused trait - [`84d7987`](https://github.com/AppFlowy-IO/AppFlowy/commit/84d7987bc7316457e3a67b99c1c14f663ff4a9cb) chore: rename group context to group controller context ### 📊 Changes **32 files changed** (+479 additions, -951 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart` (+70 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/application/group_controller.dart` (+3 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart` (+2 -2) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/group_by_multi_select_field_test.dart` (+0 -12) 📝 `frontend/appflowy_tauri/src/appflowy_app/application/database/group/group_types.ts` (+0 -2) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/group_test.rs` (+0 -14) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs` (+0 -4) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group_changeset.rs` (+4 -18) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+6 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+19 -26) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs` (+22 -60) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/views.rs` (+0 -27) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs` (+5 -20) 📝 `frontend/rust-lib/flowy-database2/src/services/group/action.rs` (+32 -18) 📝 `frontend/rust-lib/flowy-database2/src/services/group/configuration.rs` (+36 -106) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller.rs` (+57 -74) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/checkbox_controller.rs` (+13 -44) _...and 12 more files_ </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>