[PR #6512] [MERGED] fix: hide breadcrumbs for deleted pages and show trash #7430

New issue

Closed

opened 2026-03-23 23:19:35 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6512
Author: @Xazin
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @Xazin

Base: main ← Head: fix/trash-breadcrumbs

📝 Commits (7)

31017a2 fix: hide breadcrumbs for deleted pages and show trash
906bfe2 fix: copy for banner and trash deletion
672c0d2 test: add base test
a804b18 test: expand on test
07f4e37 test: fix test
8f7c010 test: fix failing test
fa29935 chore: merge branch 'upstream/main' into fix/trash-breadcrumbs

📊 Changes

10 files changed (+215 additions, -22 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/document/document_deletion_test.dart (+82 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_document/database_document_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/banner.dart (+14 -2)
📝 frontend/appflowy_flutter/lib/plugins/trash/trash_page.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/view_title/view_title_bar_bloc.dart (+34 -9)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+68 -4)
📝 frontend/resources/translations/en.json (+3 -2)

📄 Description

Closes: #5153

Feature Preview

https://github.com/user-attachments/assets/08780f7d-e0d2-426d-9f88-c6b2ec961854

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6512 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/trash-breadcrumbs` --- ### 📝 Commits (7) - [`31017a2`](https://github.com/AppFlowy-IO/AppFlowy/commit/31017a2b63041dfb61e50a4ed31dbbd72c6e1225) fix: hide breadcrumbs for deleted pages and show trash - [`906bfe2`](https://github.com/AppFlowy-IO/AppFlowy/commit/906bfe232559d0b196b6512895dc79a3e37704d2) fix: copy for banner and trash deletion - [`672c0d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/672c0d262f1d25b9cb24c4387962db4c685b06a1) test: add base test - [`a804b18`](https://github.com/AppFlowy-IO/AppFlowy/commit/a804b181aba690b1d1a56b37ef1ef40fd861b2c8) test: expand on test - [`07f4e37`](https://github.com/AppFlowy-IO/AppFlowy/commit/07f4e37b27289324cd3de4022114315ec5ee2771) test: fix test - [`8f7c010`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f7c010dda606a7fbeb10f0f6d83b814c1dfed83) test: fix failing test - [`fa29935`](https://github.com/AppFlowy-IO/AppFlowy/commit/fa29935494ff72a18bfa2a24d18bd95f268a794d) chore: merge branch 'upstream/main' into fix/trash-breadcrumbs ### 📊 Changes **10 files changed** (+215 additions, -22 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_deletion_test.dart` (+82 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_document/database_document_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/banner.dart` (+14 -2) 📝 `frontend/appflowy_flutter/lib/plugins/trash/trash_page.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/view_title/view_title_bar_bloc.dart` (+34 -9) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+68 -4) 📝 `frontend/resources/translations/en.json` (+3 -2) </details> ### 📄 Description Closes: #5153 ### Feature Preview https://github.com/user-attachments/assets/08780f7d-e0d2-426d-9f88-c6b2ec961854 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>