[PR #5011] [MERGED] feat: select option cell editor revamp #6579

New issue

Closed

opened 2026-03-23 23:15:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:15:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5011
Author: @richardshiue
Created: 3/30/2024
Status: ✅ Merged
Merged: 3/31/2024
Merged by: @richardshiue

Base: main ← Head: chore/select-option-cell-editor-revamp

📝 Commits (9)

d64af65 chore: gen new select option color on frontend
bbc6f15 chore: reorder select options
62645d0 chore: fix performance regression
2d95342 chore: add text field tap region
03ed281 chore: implement hover focus
ebbe047 chore: implement keyboard focus
1478359 chore: fix tests
2e67983 chore: reorder options in field editor
e815a30 chore: fix tests

📊 Changes

21 files changed (+1187 additions, -834 deletions)

View changed files

➕ frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_cell_editor_bloc.dart (+446 -0)
➖ frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_editor_bloc.dart (+0 -318)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/select_option_type_option_bloc.dart (+17 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/select_type_option_actions.dart (+51 -22)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/select_option_cell_service.dart (+16 -20)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_select_option_cell.dart (+12 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_select_option_cell.dart (+14 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/select_option.dart (+5 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_select_option_cell.dart (+21 -17)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_select_cell_option.dart (+45 -41)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/extension.dart (+1 -42)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart (+43 -32)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart (+359 -189)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_text_field.dart (+26 -57)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/select/select_option.dart (+77 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/select/select_option_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/group_by_multi_select_field_test.dart (+6 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/select_option_cell_test.dart (+38 -31)
📝 frontend/appflowy_flutter/test/widget_test/select_option_text_field_test.dart (+5 -7)

...and 1 more files

📄 Description

resolves #5016
resolves #4953
resolves #3339
resolves #3232
resolves #3847
resolves #3801

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5011 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 3/30/2024 **Status:** ✅ Merged **Merged:** 3/31/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/select-option-cell-editor-revamp` --- ### 📝 Commits (9) - [`d64af65`](https://github.com/AppFlowy-IO/AppFlowy/commit/d64af650d8ead101d14df2e359603b8dcc65806f) chore: gen new select option color on frontend - [`bbc6f15`](https://github.com/AppFlowy-IO/AppFlowy/commit/bbc6f1501678b5da2319c69d09287f877f2f2417) chore: reorder select options - [`62645d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/62645d075642e3484b023bfc4dd57418a50a2da6) chore: fix performance regression - [`2d95342`](https://github.com/AppFlowy-IO/AppFlowy/commit/2d95342c4e3a881bec8d0860c9fbffae97508cd0) chore: add text field tap region - [`03ed281`](https://github.com/AppFlowy-IO/AppFlowy/commit/03ed28146a28cc9cfa5c9d24f5831247d6d80c6d) chore: implement hover focus - [`ebbe047`](https://github.com/AppFlowy-IO/AppFlowy/commit/ebbe0477f6dfe904a6c05c4781544d7a1750fcd3) chore: implement keyboard focus - [`1478359`](https://github.com/AppFlowy-IO/AppFlowy/commit/14783592a8f2b7da4ac31ee0fc8b17da983d7222) chore: fix tests - [`2e67983`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e679835c1ab3bb579cc971fadc889ddb19a22b4) chore: reorder options in field editor - [`e815a30`](https://github.com/AppFlowy-IO/AppFlowy/commit/e815a308256191185a1befd63bf6b73727209e2e) chore: fix tests ### 📊 Changes **21 files changed** (+1187 additions, -834 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_cell_editor_bloc.dart` (+446 -0) ➖ `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/select_option_editor_bloc.dart` (+0 -318) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/select_option_type_option_bloc.dart` (+17 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/select_type_option_actions.dart` (+51 -22) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/select_option_cell_service.dart` (+16 -20) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_select_option_cell.dart` (+12 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_select_option_cell.dart` (+14 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/select_option.dart` (+5 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_select_option_cell.dart` (+21 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_select_cell_option.dart` (+45 -41) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/extension.dart` (+1 -42) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart` (+43 -32) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart` (+359 -189) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_text_field.dart` (+26 -57) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/select/select_option.dart` (+77 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/select/select_option_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/group_by_multi_select_field_test.dart` (+6 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/select_option_cell_test.dart` (+38 -31) 📝 `frontend/appflowy_flutter/test/widget_test/select_option_text_field_test.dart` (+5 -7) _...and 1 more files_ </details> ### 📄 Description resolves #5016 resolves #4953 resolves #3339 resolves #3232 resolves #3847 resolves #3801 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>