[PR #6579] [MERGED] fix: share link and publish issues on mobile #7472

Closed
opened 2026-03-23 23:19:47 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6579
Author: @LucasXu0
Created: 10/18/2024
Status: Merged
Merged: 10/20/2024
Merged by: @LucasXu0

Base: mainHead: fix_share_issues


📝 Commits (10+)

  • 85f02aa fix: cache publish info to avoid repeated requests
  • 3037eb9 chore: 'Copy Link' to 'Copy link'
  • 747fb97 chore: enable ios ci
  • eab116a fix: ios ci
  • 3d87f41 chore: replace mention block icon
  • fc1f855 fix: ios ci tests
  • b75d438 fix: ios ci tests
  • 7380a3c Merge branch 'main' into fix_share_issues
  • b999ead fix: ai wirte replace assertion
  • 9b6ef00 fix: windows ci

📊 Changes

19 files changed (+386 additions, -82 deletions)

View changed files

📝 .github/workflows/flutter_ci.yaml (+16 -16)
📝 .github/workflows/ios_ci.yaml (+9 -9)
📝 frontend/appflowy_flutter/integration_test/mobile/cloud/cloud_runner.dart (+4 -0)
frontend/appflowy_flutter/integration_test/mobile/cloud/document/publish_test.dart (+89 -0)
📝 frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/mobile/home_page/create_new_page_test.dart (+7 -7)
📝 frontend/appflowy_flutter/integration_test/mobile/sign_in/anonymous_sign_in_test.dart (+0 -5)
📝 frontend/appflowy_flutter/integration_test/mobile_runner.dart (+3 -0)
📝 frontend/appflowy_flutter/integration_test/shared/base.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/app_bar_buttons.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+53 -25)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/smart_edit_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart (+3 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart (+8 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/smart_edit_test/smart_editor_bloc_test.dart (+174 -5)
frontend/resources/flowy_icons/16x/paragraph_mark.svg (+3 -0)

📄 Description

Feature Preview

  • cache the publish info to avoid repeated requests
  • test: cache the publish info to avoid repeated requests
  • Copy Link -> Copy link
  • Replace the 'share link to block' icon
  • update editor version
  • ai write replace may fail if the result doesn't have the same length as the original nodes
  • test: ai write replace may fail

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6579 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 10/20/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_share_issues` --- ### 📝 Commits (10+) - [`85f02aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/85f02aab003719d8b7e8403634482a7f1dd20ae7) fix: cache publish info to avoid repeated requests - [`3037eb9`](https://github.com/AppFlowy-IO/AppFlowy/commit/3037eb96d60e76ed774f8fca91db6078372def78) chore: 'Copy Link' to 'Copy link' - [`747fb97`](https://github.com/AppFlowy-IO/AppFlowy/commit/747fb9715665958d9333627bd4f184648e30fd08) chore: enable ios ci - [`eab116a`](https://github.com/AppFlowy-IO/AppFlowy/commit/eab116a93a9185758906b38ea5b5d952e9c0d1b9) fix: ios ci - [`3d87f41`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d87f4118d7a86a15c05c8ac4f36367385395cb4) chore: replace mention block icon - [`fc1f855`](https://github.com/AppFlowy-IO/AppFlowy/commit/fc1f8550c3f8ec22e607503eabfd3dc5ec5135bc) fix: ios ci tests - [`b75d438`](https://github.com/AppFlowy-IO/AppFlowy/commit/b75d43840d5113a78a7c3a7416a3da0524f40982) fix: ios ci tests - [`7380a3c`](https://github.com/AppFlowy-IO/AppFlowy/commit/7380a3c2a9ed6381e609967c0b5cbb32df17e2a1) Merge branch 'main' into fix_share_issues - [`b999ead`](https://github.com/AppFlowy-IO/AppFlowy/commit/b999ead4b139b0d69f2d56a285bf6540e718d530) fix: ai wirte replace assertion - [`9b6ef00`](https://github.com/AppFlowy-IO/AppFlowy/commit/9b6ef002773cc6afe1cfb306c8c88a4922d88e1d) fix: windows ci ### 📊 Changes **19 files changed** (+386 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/flutter_ci.yaml` (+16 -16) 📝 `.github/workflows/ios_ci.yaml` (+9 -9) 📝 `frontend/appflowy_flutter/integration_test/mobile/cloud/cloud_runner.dart` (+4 -0) ➕ `frontend/appflowy_flutter/integration_test/mobile/cloud/document/publish_test.dart` (+89 -0) 📝 `frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/mobile/home_page/create_new_page_test.dart` (+7 -7) 📝 `frontend/appflowy_flutter/integration_test/mobile/sign_in/anonymous_sign_in_test.dart` (+0 -5) 📝 `frontend/appflowy_flutter/integration_test/mobile_runner.dart` (+3 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/base.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/app_bar_buttons.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+53 -25) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/smart_edit_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart` (+3 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart` (+8 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/smart_edit_test/smart_editor_bloc_test.dart` (+174 -5) ➕ `frontend/resources/flowy_icons/16x/paragraph_mark.svg` (+3 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] cache the publish info to avoid repeated requests - [x] test: cache the publish info to avoid repeated requests - [x] Copy Link -> Copy link - [x] Replace the 'share link to block' icon - [x] update editor version - [x] ai write replace may fail if the result doesn't have the same length as the original nodes - [x] test: ai write replace may fail <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:47 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7472
No description provided.