[PR #5878] [MERGED] feat: refactor space icon picker #7063

New issue

Closed

opened 2026-03-23 23:17:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5878
Author: @LucasXu0
Created: 8/5/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @LucasXu0

Base: main ← Head: icon_picker

📝 Commits (10+)

961b580 feat: refactor space icon picker
8ae0589 chore: optimize the _loadIconGroups function
ece2f08 feat: refactor emoji picker
81e30f1 feat: integrate icon picker into flowy_icon_emoji_picker
8e241e2 feat: support searching icon
8eed927 feat: support displaying new icons
06371c4 fix: flutter analyze
1703eeb chore: join lines
2a58991 feat: support space icon in view title
036bf4a feat: support customzing icon when creating space or managing space

📊 Changes

73 files changed (+1180 additions, -305 deletions)

View changed files

➕ frontend/appflowy_flutter/assets/icons/icons.json (+1 -0)
📝 frontend/appflowy_flutter/integration_test/shared/editor_test_operations.dart (+4 -5)
📝 frontend/appflowy_flutter/integration_test/shared/workspace.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/tab_bar.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart (+24 -18)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_skin_tone.dart (+0 -1)
➖ frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart (+0 -111)
📝 frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_date_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart (+0 -1)

...and 53 more files

📄 Description

Feature Preview

Now we support more icons for space.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5878 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/5/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `icon_picker` --- ### 📝 Commits (10+) - [`961b580`](https://github.com/AppFlowy-IO/AppFlowy/commit/961b580253b3f6d521a84f43c8fd0310283852f1) feat: refactor space icon picker - [`8ae0589`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ae0589abf96f311fd0b70bd657ea4f20c5a7434) chore: optimize the _loadIconGroups function - [`ece2f08`](https://github.com/AppFlowy-IO/AppFlowy/commit/ece2f0848ba13ac21d48fbd588d047d4f48ad028) feat: refactor emoji picker - [`81e30f1`](https://github.com/AppFlowy-IO/AppFlowy/commit/81e30f143083127b566d75a8c840722e4e091cd6) feat: integrate icon picker into flowy_icon_emoji_picker - [`8e241e2`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e241e235870866c56d6808cf0e685df96a88232) feat: support searching icon - [`8eed927`](https://github.com/AppFlowy-IO/AppFlowy/commit/8eed927c6c8bcb59351fddb47c0b4be46b0bc61a) feat: support displaying new icons - [`06371c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/06371c45d27ddb867490201af25e5cd536706013) fix: flutter analyze - [`1703eeb`](https://github.com/AppFlowy-IO/AppFlowy/commit/1703eeb8dbb0fd0b2a9a4d6c8da5bd358c7e8e92) chore: join lines - [`2a58991`](https://github.com/AppFlowy-IO/AppFlowy/commit/2a5899183dee761c122d78da2384fdbfa689986b) feat: support space icon in view title - [`036bf4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/036bf4a0dfdb5242827f5ebea43e49f62cfc6665) feat: support customzing icon when creating space or managing space ### 📊 Changes **73 files changed** (+1180 additions, -305 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/icons/icons.json` (+1 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/editor_test_operations.dart` (+4 -5) 📝 `frontend/appflowy_flutter/integration_test/shared/workspace.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/tab_bar.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart` (+24 -18) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_skin_tone.dart` (+0 -1) ➖ `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart` (+0 -111) 📝 `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_date_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart` (+0 -1) _...and 53 more files_ </details> ### 📄 Description   ### Feature Preview Now we support more icons for space. <img width="817" alt="Screenshot 2024-08-06 at 10 14 07" src="https://github.com/user-attachments/assets/720c5b65-d80c-4daa-bf23-7cfa6a257cf8">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>