[PR #7063] [MERGED] fix: issues related to the emoji icon picker #7713

New issue

Closed

opened 2026-03-23 23:20:52 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7063
Author: @asjqkkkk
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/30/2024
Merged by: @LucasXu0

Base: main ← Head: fix/icons

📝 Commits (7)

861769c fix: remove the scrolling conflict of the icon picker on macOS
fdeed9d fix: the icon is not supported in sites tab
b44094e feat: keep the icon panel open after click ramdom
fe6b7ab feat: the type of selector opened depends on the already set icon or emoji
c5ac948 feat: the skin tone of the random emoji follows the selected skin ton
082bffc fix: unit testing error
1977ddf chore: merge branch 'main' into fix/icons

📊 Changes

25 files changed (+281 additions, -91 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_calendar_test.dart (+9 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart (+10 -3)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_view_item_test.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart (+22 -3)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart (+18 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart (+14 -10)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+21 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/emoji_search_bar.dart (+20 -3)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/flowy_icon_emoji_picker.dart (+53 -11)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+21 -4)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_search_bar.dart (+19 -0)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/tab.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+6 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart (+6 -1)

...and 5 more files

📄 Description

Feature Preview

Feat: keep the icon panel open after click ramdom
Feat: the type of selector opened depends on the already set icon or emoji
Feat: the skin tone of the random emoji follows the selected skin ton
Feat: save ramdom icon in recent section
Fix: remove the scrolling conflict of the icon picker on macOS
Fix: the icon is not supported in sites tab

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7063 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/30/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/icons` --- ### 📝 Commits (7) - [`861769c`](https://github.com/AppFlowy-IO/AppFlowy/commit/861769c5ab4317d3fb4bb0087e6e5868911a294d) fix: remove the scrolling conflict of the icon picker on macOS - [`fdeed9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/fdeed9d1ab8f5a9bfea53e674e959c188aa9439b) fix: the icon is not supported in sites tab - [`b44094e`](https://github.com/AppFlowy-IO/AppFlowy/commit/b44094e5e9bc7235beeb7edd5b68b5dc1995fa16) feat: keep the icon panel open after click ramdom - [`fe6b7ab`](https://github.com/AppFlowy-IO/AppFlowy/commit/fe6b7abbf4e62ff2a5a9f650466fe4299dc59a94) feat: the type of selector opened depends on the already set icon or emoji - [`c5ac948`](https://github.com/AppFlowy-IO/AppFlowy/commit/c5ac94846585759fef160cbf43abc3868683b99a) feat: the skin tone of the random emoji follows the selected skin ton - [`082bffc`](https://github.com/AppFlowy-IO/AppFlowy/commit/082bffcae35a49a6e8191571779c6e7d3e65bbd3) fix: unit testing error - [`1977ddf`](https://github.com/AppFlowy-IO/AppFlowy/commit/1977ddfc95acda6c3be060957ea73d36139dee69) chore: merge branch 'main' into fix/icons ### 📊 Changes **25 files changed** (+281 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_calendar_test.dart` (+9 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart` (+10 -3) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_view_item_test.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart` (+22 -3) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart` (+18 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart` (+14 -10) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+21 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/emoji_search_bar.dart` (+20 -3) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/flowy_icon_emoji_picker.dart` (+53 -11) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+21 -4) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_search_bar.dart` (+19 -0) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/tab.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+6 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart` (+6 -1) _...and 5 more files_ </details> ### 📄 Description ### Feature Preview - Feat: keep the icon panel open after click ramdom - Feat: the type of selector opened depends on the already set icon or emoji - Feat: the skin tone of the random emoji follows the selected skin ton - Feat: save ramdom icon in recent section - Fix: remove the scrolling conflict of the icon picker on macOS - Fix: the icon is not supported in sites tab #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>