[PR #6435] [MERGED] feat: keep link format when converting preview block to text #7379

New issue

Closed

opened 2026-03-23 23:19:20 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6435
Author: @LucasXu0
Created: 9/30/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @LucasXu0

Base: main ← Head: link_preview_on_mobile

📝 Commits (6)

480485b feat: keep link format when converting preview block to text
94d088a test: add test
10bc4e1 fix: flutter analyze
7743d22 feat: ctrl/cmd+z to revert the link prevew op
b33ca4d test: add test
f42c648 chore: update toast style

📊 Changes

6 files changed (+143 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_copy_and_paste_test.dart (+68 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_block_action_widget.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart (+35 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/link_preview_menu.dart (+8 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/shared.dart (+17 -4)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/5426

unable to open preview block on mobile
keep link format when converting preview block to text
replace the icons in 'more actions' bottom sheet.
add test

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6435 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `link_preview_on_mobile` --- ### 📝 Commits (6) - [`480485b`](https://github.com/AppFlowy-IO/AppFlowy/commit/480485ba1152e3c79a7792482c741aa9223f3df0) feat: keep link format when converting preview block to text - [`94d088a`](https://github.com/AppFlowy-IO/AppFlowy/commit/94d088af3fd42597eaebb2c35c298e4d8f71b879) test: add test - [`10bc4e1`](https://github.com/AppFlowy-IO/AppFlowy/commit/10bc4e176450d839561a012bf9d3921ec4e673da) fix: flutter analyze - [`7743d22`](https://github.com/AppFlowy-IO/AppFlowy/commit/7743d2250a8a1b240936a7c5bc6fd23d26900a52) feat: ctrl/cmd+z to revert the link prevew op - [`b33ca4d`](https://github.com/AppFlowy-IO/AppFlowy/commit/b33ca4de11312a720dda45725161ce89dcce2acb) test: add test - [`f42c648`](https://github.com/AppFlowy-IO/AppFlowy/commit/f42c648434590f38193eb3f7bd1a26dc2dd99e21) chore: update toast style ### 📊 Changes **6 files changed** (+143 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_copy_and_paste_test.dart` (+68 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_block_action_widget.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart` (+35 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/link_preview_menu.dart` (+8 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/shared.dart` (+17 -4) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/5426 - [x] unable to open preview block on mobile - [x] keep link format when converting preview block to text - [x] replace the icons in 'more actions' bottom sheet. - [x] add test <img width="519" alt="Screenshot 2024-09-30 at 17 54 34" src="https://github.com/user-attachments/assets/50b135f6-7c87-4907-9cbe-87dfa4f1c2a1"> <img width="469" alt="Screenshot 2024-09-30 at 18 15 14" src="https://github.com/user-attachments/assets/5c579e65-8f37-43f3-bc3d-401ab047ce3e">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>