[PR #7379] [MERGED] fix: some launch review issues #7857

New issue

Closed

opened 2026-03-23 23:21:30 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7379
Author: @asjqkkkk
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @LucasXu0

Base: main ← Head: fix/launch_review

📝 Commits (6)

c7da516 fix: some launch review issues
71f880b fix: some launch review issues
8a61b04 fix: some launch review issues
4e3d085 Merge branch 'main' into fix/launch_review
0044b6f feat: add change button for icon uploader
b6d3e96 Merge branch 'main' into fix/launch_review

📊 Changes

20 files changed (+476 additions, -150 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/mobile/document/slash_menu_test.dart (+12 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+7 -5)
📝 frontend/appflowy_flutter/lib/mobile/presentation/inline_actions/mobile_inline_actions_menu_group.dart (+8 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu.dart (+10 -5)
📝 frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_item_widget.dart (+39 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart (+87 -24)
➕ frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/slash_keyboard_service_interceptor.dart (+42 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_drop_handler.dart (+14 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_drop_manager.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_command.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/mobile_items.dart (+20 -45)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/simple_table_item.dart (+12 -0)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart (+16 -5)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart (+149 -25)
📝 frontend/appflowy_flutter/lib/shared/markdown_to_document.dart (+29 -21)
➕ frontend/appflowy_flutter/macos/build/ios/XCBuildData/PIFCache/project/PROJECT@v11_mod=a7fbf46937053896f73cc7c7ec6baefb_hash=bfdfe7dc352907fc980b868725387e98plugins=1OJSG6M1FOV3XYQCBH7Z29RZ0FPR9XDE1-json (+1 -0)
➕ frontend/appflowy_flutter/macos/build/ios/XCBuildData/PIFCache/workspace/WORKSPACE@v11_hash=(null)_subobjects=9b6915bad2214bcc5eb58b855fe7b55a-json (+1 -0)
➕ frontend/resources/flowy_icons/16x/slash_menu_icon_visuals.svg (+7 -0)
📝 frontend/resources/translations/en.json (+14 -2)

📄 Description

Fix the issue listed below：

the slash menu position is incorrect
The title doesn’t display properly
the arrow in the menu is not visible on dark mode
mention page icon is cropped. See: paper clip icon
table and date or reminder should have no second leven menu
presses backspace to return first layer
slash menu reorganization
add change button for icon uploader
enable dragging a svg file to upload as icon

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7379 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/launch_review` --- ### 📝 Commits (6) - [`c7da516`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7da516562434699b4d6e7efc801b0b06b6985d1) fix: some launch review issues - [`71f880b`](https://github.com/AppFlowy-IO/AppFlowy/commit/71f880b2cef1e0760174c91cf920a36a5b8404e5) fix: some launch review issues - [`8a61b04`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a61b04f35d01691ee24676baa0a4be068c02273) fix: some launch review issues - [`4e3d085`](https://github.com/AppFlowy-IO/AppFlowy/commit/4e3d08504618c5c2c7e0b2ecc018fa1fe0f281ca) Merge branch 'main' into fix/launch_review - [`0044b6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/0044b6fa19891c131e34203d355b3f1f7b47c04b) feat: add change button for icon uploader - [`b6d3e96`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6d3e9664b33237205359e7fe1c48672a2ac07d0) Merge branch 'main' into fix/launch_review ### 📊 Changes **20 files changed** (+476 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/mobile/document/slash_menu_test.dart` (+12 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+7 -5) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/inline_actions/mobile_inline_actions_menu_group.dart` (+8 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu.dart` (+10 -5) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_item_widget.dart` (+39 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart` (+87 -24) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/slash_keyboard_service_interceptor.dart` (+42 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_drop_handler.dart` (+14 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_drop_manager.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_command.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/mobile_items.dart` (+20 -45) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/simple_table_item.dart` (+12 -0) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart` (+16 -5) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart` (+149 -25) 📝 `frontend/appflowy_flutter/lib/shared/markdown_to_document.dart` (+29 -21) ➕ `frontend/appflowy_flutter/macos/build/ios/XCBuildData/PIFCache/project/PROJECT@v11_mod=a7fbf46937053896f73cc7c7ec6baefb_hash=bfdfe7dc352907fc980b868725387e98plugins=1OJSG6M1FOV3XYQCBH7Z29RZ0FPR9XDE1-json` (+1 -0) ➕ `frontend/appflowy_flutter/macos/build/ios/XCBuildData/PIFCache/workspace/WORKSPACE@v11_hash=(null)_subobjects=9b6915bad2214bcc5eb58b855fe7b55a-json` (+1 -0) ➕ `frontend/resources/flowy_icons/16x/slash_menu_icon_visuals.svg` (+7 -0) 📝 `frontend/resources/translations/en.json` (+14 -2) </details> ### 📄 Description Fix the issue listed below： - the slash menu position is incorrect - The title doesn’t display properly - the arrow in the menu is not visible on dark mode - mention page icon is cropped. See: paper clip icon - `table` and `date or reminder` should have no second leven menu - presses backspace to return first layer - slash menu reorganization - add `change` button for icon uploader - enable dragging a svg file to upload as icon   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>