[PR #6769] [MERGED] feat: i18n for duplicated field names #7568

New issue

Closed

opened 2026-03-23 23:20:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6769
Author: @Ahad-patel
Created: 11/12/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @LucasXu0

Base: main ← Head: duplicate-fields-i18n

📝 Commits (4)

b021c55 feat: i18n for duplicated field names
3fe3607 Merge branch 'main' into duplicate-fields-i18n
280f0ce Merge branch 'main' into duplicate-fields-i18n
752b0e5 fix: flutter analyze

📊 Changes

3 files changed (+7 additions, -3 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart (+3 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/resources/translations/en.json (+2 -1)

📄 Description

closes: #4153

Feature Preview

We can pass the copy from suffix param, this will not require to add i18n string for copy in from the rust side. I have added a new key, as per the convention used. Should I use an existing key? as there will be no translations for this. @richardshiue

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6769 **Author:** [@Ahad-patel](https://github.com/Ahad-patel) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `duplicate-fields-i18n` --- ### 📝 Commits (4) - [`b021c55`](https://github.com/AppFlowy-IO/AppFlowy/commit/b021c55ac86a1a2236f64ca99668033b7d2ff973) feat: i18n for duplicated field names - [`3fe3607`](https://github.com/AppFlowy-IO/AppFlowy/commit/3fe3607f699ddcb4d6a35f30e0f2455e8ae27c59) Merge branch 'main' into duplicate-fields-i18n - [`280f0ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/280f0ce200f7eb2491bbe81d706205d009e3309b) Merge branch 'main' into duplicate-fields-i18n - [`752b0e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/752b0e5f420b8097c219ad891351f39aad70719b) fix: flutter analyze ### 📊 Changes **3 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart` (+3 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/resources/translations/en.json` (+2 -1) </details> ### 📄 Description   closes: #4153 ### Feature Preview  We can pass the copy from suffix param, this will not require to add i18n string for copy in from the rust side. I have added a new key, as per the convention used. Should I use an existing key? as there will be no translations for this. @richardshiue ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>