[PR #7568] [MERGED] fix: optimize cover title position offset calculation #7969

New issue

Closed

opened 2026-03-23 23:22:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7568
Author: @LucasXu0
Created: 3/18/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @LucasXu0

Base: main ← Head: optimize_title_position

📝 Commits (2)

e1a8fc1 fix: optimize cover title position offset calculation
8a8d129 feat: ingore shift+enter in callout/quote and fallback to system behavior

📊 Changes

3 files changed (+50 additions, -36 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_shortcuts.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart (+46 -33)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/quote/quote_block_shortcuts.dart (+2 -2)

📄 Description

Feature Preview

Use padding instead of positioned in cover title and cover icon
Ingore shift+enter in callout/quote and fallback to system behavior

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7568 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `optimize_title_position` --- ### 📝 Commits (2) - [`e1a8fc1`](https://github.com/AppFlowy-IO/AppFlowy/commit/e1a8fc16dc32d7316d56f649f327b1a7b97638bb) fix: optimize cover title position offset calculation - [`8a8d129`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a8d129c1aa69c22d7953f3d7cbd919b024d8fe1) feat: ingore shift+enter in callout/quote and fallback to system behavior ### 📊 Changes **3 files changed** (+50 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_shortcuts.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart` (+46 -33) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/quote/quote_block_shortcuts.dart` (+2 -2) </details> ### 📄 Description   ### Feature Preview - Use padding instead of positioned in cover title and cover icon - Ingore shift+enter in callout/quote and fallback to system behavior  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>