[PR #7236] [MERGED] feat: support custom image icon #7799

Closed
opened 2026-03-23 23:21:15 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7236
Author: @asjqkkkk
Created: 1/18/2025
Status: Merged
Merged: 1/21/2025
Merged by: @LucasXu0

Base: mainHead: feat/icons/custom


📝 Commits (5)

  • f3465dc feat: supporting upload custom image as icon
  • 2590f65 feat: support custom image icon on mobile
  • e11c2cc Merge branch 'main' into feat/icons/custom
  • 7d428d2 Merge branch 'main' into feat/icons/custom
  • a42cc41 chore: clean code

📊 Changes

32 files changed (+601 additions, -28 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart (+50 -0)
frontend/appflowy_flutter/integration_test/mobile/document/icon_test.dart (+65 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+41 -0)
📝 frontend/appflowy_flutter/integration_test/shared/expectation.dart (+30 -0)
📝 frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/app_bar_buttons.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/section_folder/mobile_home_section_folder.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart (+13 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/application/chat_select_message_bloc.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart (+20 -0)

...and 12 more files

📄 Description

Feature Preview

  • support upload custom images as icon

On desktop:

https://github.com/user-attachments/assets/e2590cf3-ee28-4196-8cdd-2fe714113589

On mobile:

https://github.com/user-attachments/assets/f8df3293-7526-4253-a711-34a85dd429da


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7236 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/icons/custom` --- ### 📝 Commits (5) - [`f3465dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/f3465dc16bcb49bcbb0f61e45be81f4ce02603d0) feat: supporting upload custom image as icon - [`2590f65`](https://github.com/AppFlowy-IO/AppFlowy/commit/2590f65df625367f5d0c44ffcea0af1bd6a8876f) feat: support custom image icon on mobile - [`e11c2cc`](https://github.com/AppFlowy-IO/AppFlowy/commit/e11c2cc03c4a08cda3f9bb1dbf50aa1c98151686) Merge branch 'main' into feat/icons/custom - [`7d428d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/7d428d2c31064db1cde4e5e636396707412a8b01) Merge branch 'main' into feat/icons/custom - [`a42cc41`](https://github.com/AppFlowy-IO/AppFlowy/commit/a42cc410b7c3859522b8ab48679966c6bd4bf5e8) chore: clean code ### 📊 Changes **32 files changed** (+601 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart` (+50 -0) ➕ `frontend/appflowy_flutter/integration_test/mobile/document/icon_test.dart` (+65 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+41 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/expectation.dart` (+30 -0) 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/app_bar_buttons.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/section_folder/mobile_home_section_folder.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart` (+13 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/application/chat_select_message_bloc.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart` (+20 -0) _...and 12 more files_ </details> ### 📄 Description ### Feature Preview - support upload custom images as icon **On desktop:** https://github.com/user-attachments/assets/e2590cf3-ee28-4196-8cdd-2fe714113589 **On mobile:** https://github.com/user-attachments/assets/f8df3293-7526-4253-a711-34a85dd429da <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7799
No description provided.