[PR #7799] [MERGED] feat: add loading indicator in continue to sign in button #8120

New issue

Closed

opened 2026-03-23 23:22:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7799
Author: @LucasXu0
Created: 4/21/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @LucasXu0

Base: main ← Head: loading_indicator_button

📝 Commits (1)

2b5e265 feat: add loading indicator in continue to sign in button

📊 Changes

1 file changed (+59 additions, -15 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/continue_with/continue_with_magic_link_or_passcode_page.dart (+59 -15)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Add a loading indicator to the continue to sign in button when submitting a passcode

New Features:

Implement a loading state with a circular progress indicator when submitting a passcode during sign-in

Enhancements:

Improve user experience by providing visual feedback during passcode submission
Dynamically adjust loading indicator size based on button text style

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7799 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/21/2025 **Status:** ✅ Merged **Merged:** 4/22/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `loading_indicator_button` --- ### 📝 Commits (1) - [`2b5e265`](https://github.com/AppFlowy-IO/AppFlowy/commit/2b5e265a6025c6da63264da7c90648a7aa52bcf0) feat: add loading indicator in continue to sign in button ### 📊 Changes **1 file changed** (+59 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/continue_with/continue_with_magic_link_or_passcode_page.dart` (+59 -15) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Add a loading indicator to the continue to sign in button when submitting a passcode New Features: - Implement a loading state with a circular progress indicator when submitting a passcode during sign-in Enhancements: - Improve user experience by providing visual feedback during passcode submission - Dynamically adjust loading indicator size based on button text style --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>