[PR #7905] [MERGED] fix: allow ':keyword' make mistakes #8201

New issue

Closed

opened 2026-03-23 23:23:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7905
Author: @asjqkkkk
Created: 5/9/2025
Status: ✅ Merged
Merged: 5/13/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/emoji

📝 Commits (2)

0b3d66b fix: allow ':keyword' make mistakes
d2501b6 Merge branch 'main' into fix/desktop/emoji

📊 Changes

1 file changed (+26 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart (+26 -4)

📄 Description

When inserting an emoji by using “:”, allow the continuation of input with a string of up to 5 characters even if no results are found

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve emoji search input handling by allowing users to continue typing and exploring emoji suggestions even when initial results are empty

Bug Fixes:

Prevent premature dismissal of emoji picker when no initial results are found

Enhancements:

Extend emoji search input tolerance to allow continued typing up to 5 additional characters
Add a 'no results' message when no emojis match the current search query

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7905 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/emoji` --- ### 📝 Commits (2) - [`0b3d66b`](https://github.com/AppFlowy-IO/AppFlowy/commit/0b3d66b505711578d94a25eb4a92eaeceb7564e2) fix: allow ':keyword' make mistakes - [`d2501b6`](https://github.com/AppFlowy-IO/AppFlowy/commit/d2501b62ce793c07b5bd021908e233f236f35ecf) Merge branch 'main' into fix/desktop/emoji ### 📊 Changes **1 file changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart` (+26 -4) </details> ### 📄 Description When inserting an emoji by using “:”, allow the continuation of input with a string of up to 5 characters even if no results are found ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve emoji search input handling by allowing users to continue typing and exploring emoji suggestions even when initial results are empty Bug Fixes: - Prevent premature dismissal of emoji picker when no initial results are found Enhancements: - Extend emoji search input tolerance to allow continued typing up to 5 additional characters - Add a 'no results' message when no emojis match the current search query --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>