[PR #8201] [CLOSED] Fix for #8200: add PLN (Polish Złoty) number format support #8312

New issue

Closed

opened 2026-03-23 23:23:35 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8201
Author: @julianengel
Created: 8/29/2025
Status: ❌ Closed

Base: main ← Head: feat/add-pln-number-format

📝 Commits (1)

04adce1 PR: add PLN (Polish Złoty) number format support

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/number_format_bloc.dart (+4 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/number_entities.rs (+3 -0)

📄 Description

This PR adds support for PLN (Polish Złoty) as a number format option in the database fields.

Add PLN = 37 to NumberFormatPB enum in Rust
Add conversion mappings between NumberFormat::PLN and NumberFormatPB::PLN
Add "Polish złoty" title and "zł" symbol in Flutter UI

Note: This requires corresponding NumberFormat::PLN to be added in the collab-database dependency (AppFlowy-Collab repository).

Changes needed in collab-database:

In the NumberFormat enum (likely in a file similar to fields/number_type_option.rs), add: PLN = 37,

Feature Preview

This addresses the following issue: https://github.com/AppFlowy-IO/AppFlowy/issues/8200

However, a change to collab-database is required for it to be a fix.

Also, this may need to be adjusted for https://github.com/AppFlowy-IO/AppFlowy-Web

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing - they will be once it's added to collab-database

Summary by Sourcery

Add support for the Polish złoty (PLN) number format by extending the Rust NumberFormatPB enum with conversion mappings and updating the Flutter UI with the corresponding label and symbol.

New Features:

Introduce PLN variant to NumberFormatPB enum and mapping in Rust
Display "Polish złoty" title and "zł" symbol for PLN in the Flutter UI

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8201 **Author:** [@julianengel](https://github.com/julianengel) **Created:** 8/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/add-pln-number-format` --- ### 📝 Commits (1) - [`04adce1`](https://github.com/AppFlowy-IO/AppFlowy/commit/04adce166eb88449c691be5fa98c7ca55224b0f6) PR: add PLN (Polish Złoty) number format support ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/number_format_bloc.dart` (+4 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/number_entities.rs` (+3 -0) </details> ### 📄 Description This PR adds support for PLN (Polish Złoty) as a number format option in the database fields. - Add PLN = 37 to NumberFormatPB enum in Rust - Add conversion mappings between NumberFormat::PLN and NumberFormatPB::PLN - Add "Polish złoty" title and "zł" symbol in Flutter UI **Note:** This requires corresponding NumberFormat::PLN to be added in the collab-database dependency (AppFlowy-Collab repository). Changes needed in collab-database: `In the NumberFormat enum (likely in a file similar to fields/number_type_option.rs), add: PLN = 37, `  ### Feature Preview This addresses the following issue: https://github.com/AppFlowy-IO/AppFlowy/issues/8200 However, a change to `collab-database` is required for it to be a fix. Also, this may need to be adjusted for https://github.com/AppFlowy-IO/AppFlowy-Web #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing - they will be once it's added to `collab-database` ## Summary by Sourcery Add support for the Polish złoty (PLN) number format by extending the Rust NumberFormatPB enum with conversion mappings and updating the Flutter UI with the corresponding label and symbol. New Features: - Introduce PLN variant to NumberFormatPB enum and mapping in Rust - Display "Polish złoty" title and "zł" symbol for PLN in the Flutter UI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>