[PR #8070] fix: regression in handling on non-standard URLs on Windows #8291

New issue

Open

opened 2026-03-23 23:23:30 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/8070
Author: @asjqkkkk
Created: 6/17/2025
Status: 🔄 Open

Base: main ← Head: fix/issue/8050

📝 Commits (3)

1d038f1 fix: regression in handling on non-standard URLs on Windows
15ba348 Merge branch 'main' into fix/issue/8050
1269b5b chore: typo issue

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+7 -2)

📄 Description

To fix #8050

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refine URL handling to prevent unintentional protocol prepending for custom editor URLs on Windows while preserving scheme addition for standard links on Linux and Android.

Bug Fixes:

Skip adding default protocol to custom URLs on Windows to restore correct link launching behavior.

Enhancements:

Refine URL launcher logic by introducing a Windows-specific custom URL check with isCustomUrL.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/8070 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 6/17/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/issue/8050` --- ### 📝 Commits (3) - [`1d038f1`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d038f1c78c8c00ecbb6d65ef47d06f7889ef4a3) fix: regression in handling on non-standard URLs on Windows - [`15ba348`](https://github.com/AppFlowy-IO/AppFlowy/commit/15ba348ee17f92dbe1600bf0079e2d3556bcee24) Merge branch 'main' into fix/issue/8050 - [`1269b5b`](https://github.com/AppFlowy-IO/AppFlowy/commit/1269b5b6317d8ddb799f9902f3af17caf36ae547) chore: typo issue ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+7 -2) </details> ### 📄 Description To fix #8050 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refine URL handling to prevent unintentional protocol prepending for custom editor URLs on Windows while preserving scheme addition for standard links on Linux and Android. Bug Fixes: - Skip adding default protocol to custom URLs on Windows to restore correct link launching behavior. Enhancements: - Refine URL launcher logic by introducing a Windows-specific custom URL check with isCustomUrL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>