AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #2069] [FR] Allow users to select a language in the quick start page #837

New issue

Closed

opened 2026-03-23 20:41:47 +00:00 by mirror · 15 comments

mirror commented

2026-03-23 20:41:47 +00:00

Owner

Originally created by @annieappflowy on GitHub (Mar 21, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2069

Description

Users can switch to another language (or maybe ideally it matches their system language automatically.

Impact

All the users

Additional Context

No response

Originally created by @annieappflowy on GitHub (Mar 21, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2069 ### Description <img width="807" alt="image" src="https://user-images.githubusercontent.com/12026239/226617876-4ed5db5a-7e1d-45cf-8284-fee6ca6f590a.png"> Users can switch to another language (or maybe ideally it matches their system language automatically. ### Impact All the users ### Additional Context _No response_

mirror

2026-03-23 20:41:47 +00:00

closed this issue
added the
new feature
label

mirror commented

2026-03-23 20:41:47 +00:00

Author

Owner

@Om-Gujarathi commented on GitHub (Mar 25, 2023):

I would like to work on this!
Also, if you could guide me on where to place the selector on the welcome page, as I'm not entirely sure if the placement I've chosen is optimal.

@Om-Gujarathi commented on GitHub (Mar 25, 2023): I would like to work on this! Also, if you could guide me on where to place the selector on the welcome page, as I'm not entirely sure if the placement I've chosen is optimal. <img width="863" alt="Alternative" src="https://user-images.githubusercontent.com/98649066/227716425-1abac652-29f7-45dd-807f-87adb3c8a6b7.png">

mirror commented

2026-03-23 20:41:48 +00:00

Author

Owner

@annieappflowy commented on GitHub (Mar 27, 2023):

Thanks for offering the help. @Om-Gujarathi , your design looks good to me.
Adding @hyj1204 for a second opinion.

@annieappflowy commented on GitHub (Mar 27, 2023): Thanks for offering the help. @Om-Gujarathi , your design looks good to me. Adding @hyj1204 for a second opinion.

mirror commented

2026-03-23 20:41:48 +00:00

Author

Owner

@hyj1204 commented on GitHub (Mar 27, 2023):

Since the original design is center aligned, I feel it would be better to maintain a consistent visual layout.
I made a design to move the selector to the center, right below the Appflowy logo, which indicates the current language selection of the app.
What do you think? @annieappflowy @Om-Gujarathi

@hyj1204 commented on GitHub (Mar 27, 2023): Since the original design is center aligned, I feel it would be better to maintain a consistent visual layout. I made a design to move the selector to the center, right below the Appflowy logo, which indicates the current language selection of the app. What do you think? @annieappflowy @Om-Gujarathi ![image](https://user-images.githubusercontent.com/14248245/228033899-224533cc-8534-42d3-9d57-4960d52387f5.png)

mirror commented

2026-03-23 20:41:48 +00:00

Author

Owner

@annieappflowy commented on GitHub (Mar 28, 2023):

I'd prefer to let Quick Start be the focus

@annieappflowy commented on GitHub (Mar 28, 2023): I'd prefer to let `Quick Start` be the focus

mirror commented

2026-03-23 20:41:48 +00:00

Author

Owner

@Xazin commented on GitHub (Mar 28, 2023):

Since the original design is center aligned, I feel it would be better to maintain a consistent visual layout. I made a design to move the selector to the center, right below the Appflowy logo, which indicates the current language selection of the app. What do you think? @annieappflowy @Om-Gujarathi

Maybe moving the language selector to the bottom?

@Xazin commented on GitHub (Mar 28, 2023): > Since the original design is center aligned, I feel it would be better to maintain a consistent visual layout. I made a design to move the selector to the center, right below the Appflowy logo, which indicates the current language selection of the app. What do you think? @annieappflowy @Om-Gujarathi ![image](https://user-images.githubusercontent.com/14248245/228033899-224533cc-8534-42d3-9d57-4960d52387f5.png) Maybe moving the language selector to the bottom?

mirror commented

2026-03-23 20:41:49 +00:00

Author

Owner

@Om-Gujarathi commented on GitHub (Mar 28, 2023):

After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work:

Please let me know what you think, I'm open to any other suggestions.

@Om-Gujarathi commented on GitHub (Mar 28, 2023): After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work: <img width="949" alt="AppFlowy WP" src="https://user-images.githubusercontent.com/98649066/228305093-21168290-ee46-4fcb-8293-864daa06d8e5.png"> Please let me know what you think, I'm open to any other suggestions.

mirror commented

2026-03-23 20:41:49 +00:00

Author

Owner

@Xazin commented on GitHub (Mar 28, 2023):

After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work:

Please let me know what you think, I'm open to any other suggestions.

Do you have a link to the original design of the screen? Or can you link me to the figma file of your version if not (or both) 🙏

Edit: Just noticed you work directly in the code, but maybe you have a link to the original none the less?

@Xazin commented on GitHub (Mar 28, 2023): > After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work: > > <img alt="AppFlowy WP" width="949" src="https://user-images.githubusercontent.com/98649066/228305093-21168290-ee46-4fcb-8293-864daa06d8e5.png"> > > Please let me know what you think, I'm open to any other suggestions. Do you have a link to the original design of the screen? Or can you link me to the figma file of your version if not (or both) :pray: Edit: Just noticed you work directly in the code, but maybe you have a link to the original none the less?

mirror commented

2026-03-23 20:41:49 +00:00

Author

Owner

@Om-Gujarathi commented on GitHub (Mar 29, 2023):

After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work:

Please let me know what you think, I'm open to any other suggestions.

Do you have a link to the original design of the screen? Or can you link me to the figma file of your version if not (or both) 🙏

Edit: Just noticed you work directly in the code, but maybe you have a link to the original none the less?

Unfortunately, I do not have any links to the original design or a Figma file of my version. I work directly in the code, so I don't have access to those files.

@Om-Gujarathi commented on GitHub (Mar 29, 2023): > > After considering the feedback I received, I'm open to any design that you think would work best for the welcome page. However, I personally believe that the language selector should be placed in the bottom half of the page, just like @annieappflowy @Xazin said. To continue with the center alignment of the welcome page as @hyj1204 said, this design might work: > > > > <img alt="AppFlowy WP" width="949" src="https://user-images.githubusercontent.com/98649066/228305093-21168290-ee46-4fcb-8293-864daa06d8e5.png"> > > > > Please let me know what you think, I'm open to any other suggestions. > > Do you have a link to the original design of the screen? Or can you link me to the figma file of your version if not (or both) :pray: > > Edit: Just noticed you work directly in the code, but maybe you have a link to the original none the less? Unfortunately, I do not have any links to the original design or a Figma file of my version. I work directly in the code, so I don't have access to those files.

mirror commented

2026-03-23 20:41:50 +00:00

Author

Owner

@annieappflowy commented on GitHub (Mar 30, 2023):

Looks good!

@annieappflowy commented on GitHub (Mar 30, 2023): Looks good!

mirror commented

2026-03-23 20:41:50 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 3, 2023):

Hi @Om-Gujarathi , I hope we can get your PR merged soon so that users can enjoy the benefit of switching languages from the very beginning. Please don't hesitate to reach out if you need more help.

@annieappflowy commented on GitHub (Apr 3, 2023): Hi @Om-Gujarathi , I hope we can get your PR merged soon so that users can enjoy the benefit of switching languages from the very beginning. Please don't hesitate to reach out if you need more help.

mirror commented

2026-03-23 20:41:50 +00:00

Author

Owner

@Om-Gujarathi commented on GitHub (Apr 3, 2023):

Actually my work on adding the language selector feature is completed, but everything was working perfectly until I pulled the latest code.
WelcomePage

Specifically, the welcome text and language selector menu that I added are not clearly visible.
I would appreciate any suggestions or advice that you can offer on how to fix this.

@Om-Gujarathi commented on GitHub (Apr 3, 2023): Actually my work on adding the language selector feature is completed, but everything was working perfectly until I pulled the latest code. <img width="950" alt="WelcomePage" src="https://user-images.githubusercontent.com/98649066/229573567-0a5620ea-6601-4e7d-95ee-a736c13d65b8.png"> Specifically, the welcome text and language selector menu that I added are not clearly visible. I would appreciate any suggestions or advice that you can offer on how to fix this.

mirror commented

2026-03-23 20:41:51 +00:00

Author

Owner

@Xazin commented on GitHub (Apr 3, 2023):

Actually my work on adding the language selector feature is completed, but everything was working perfectly until I pulled the latest code.

Specifically, the welcome text and language selector menu that I added are not clearly visible. I would appreciate any suggestions or advice that you can offer on how to fix this.

Can you link me to your branch? I'd like to take a look

@Xazin commented on GitHub (Apr 3, 2023): > Actually my work on adding the language selector feature is completed, but everything was working perfectly until I pulled the latest code. <img alt="WelcomePage" width="950" src="https://user-images.githubusercontent.com/98649066/229573567-0a5620ea-6601-4e7d-95ee-a736c13d65b8.png"> > > Specifically, the welcome text and language selector menu that I added are not clearly visible. I would appreciate any suggestions or advice that you can offer on how to fix this. Can you link me to your branch? I'd like to take a look

mirror commented

2026-03-23 20:41:51 +00:00

Author

Owner

@hyj1204 commented on GitHub (Apr 3, 2023):

@Om-Gujarathi @Xazin
I believe the issue come from the background color didn't get updated in the dark mode. I just fixed it in the commit with my latest PR #2160

@hyj1204 commented on GitHub (Apr 3, 2023): @Om-Gujarathi @Xazin I believe the issue come from the background color didn't get updated in the dark mode. I just fixed it in the [commit](https://github.com/AppFlowy-IO/AppFlowy/pull/2160/commits/a4966c2a9263713bb9568463698bd053e8db24bd) with my latest PR #2160

mirror commented

2026-03-23 20:41:51 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 24, 2023):

https://github.com/AppFlowy-IO/AppFlowy/pull/2188

@annieappflowy commented on GitHub (Apr 24, 2023): https://github.com/AppFlowy-IO/AppFlowy/pull/2188

mirror commented

2026-03-23 20:41:51 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jun 16, 2023):

@annieappflowy commented on GitHub (Jun 16, 2023): ![Image](https://github.com/AppFlowy-IO/AppFlowy/assets/12026239/958f9e5b-96fe-44a6-b8b5-2a1eb9b8d75b)

mirror referenced this issue

2026-03-23 21:37:32 +00:00

[PR #837] [CLOSED] feat: Implement tab indentation in bulleted list #4377