[GH-ISSUE #2277] [FR] Support checkbox markdown #940

Closed
opened 2026-03-23 20:43:22 +00:00 by mirror · 11 comments
Owner

Originally created by @annieappflowy on GitHub (Apr 17, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2277

Originally assigned to: @literalEval on GitHub.

Description

As described in the title

Impact

Users who use markdown to insert a checkbox

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 17, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2277 Originally assigned to: @literalEval on GitHub. ### Description As described in the title ### Impact Users who use markdown to insert a checkbox ### Additional Context _No response_
Author
Owner

@literalEval commented on GitHub (Apr 17, 2023):

@annieappflowy I would like to work on this issue :)

<!-- gh-comment-id:1511853134 --> @literalEval commented on GitHub (Apr 17, 2023): @annieappflowy I would like to work on this issue :)
Author
Owner

@annieappflowy commented on GitHub (Apr 17, 2023):

Thanks @literalEval for offering the help. Assigned
There might be conflict between - to trigger a bulleted list and - [ ] to trigger a checkbox.

<!-- gh-comment-id:1512243340 --> @annieappflowy commented on GitHub (Apr 17, 2023): Thanks @literalEval for offering the help. Assigned There might be conflict between `-` to trigger a bulleted list and `- [ ]` to trigger a checkbox.
Author
Owner

@literalEval commented on GitHub (Apr 18, 2023):

Noted :)

<!-- gh-comment-id:1512432164 --> @literalEval commented on GitHub (Apr 18, 2023): Noted :)
Author
Owner

@literalEval commented on GitHub (Apr 18, 2023):

@annieappflowy just a quick question which I could not find in the contributing docs.
Which branch should I use as a base for changes? main or develop? Because I see some PRs being merged into main too.

<!-- gh-comment-id:1512503529 --> @literalEval commented on GitHub (Apr 18, 2023): @annieappflowy just a quick question which I could not find in the contributing docs. Which branch should I use as a base for changes? `main` or `develop`? Because I see some PRs being merged into `main` too.
Author
Owner

@annieappflowy commented on GitHub (Apr 18, 2023):

I suppose main should be fine

<!-- gh-comment-id:1512519701 --> @annieappflowy commented on GitHub (Apr 18, 2023): I suppose `main` should be fine
Author
Owner

@literalEval commented on GitHub (Apr 18, 2023):

Thanks :)

<!-- gh-comment-id:1512525243 --> @literalEval commented on GitHub (Apr 18, 2023): Thanks :)
Author
Owner

@literalEval commented on GitHub (Apr 18, 2023):

@annieappflowy since I am new to this codebase, I am having trouble finding the code that controls this. I looked at this PR, but seems like many things have changes since this, as I couldn't find the code that was added in this said PR. Any help will be helpful :)

<!-- gh-comment-id:1513621587 --> @literalEval commented on GitHub (Apr 18, 2023): @annieappflowy since I am new to this codebase, I am having trouble finding the code that controls this. I looked at [this PR](https://github.com/AppFlowy-IO/AppFlowy/pull/733), but seems like many things have changes since this, as I couldn't find the code that was added in this said PR. Any help will be helpful :)
Author
Owner

@literalEval commented on GitHub (Apr 19, 2023):

@annieappflowy I played with AppFlowy manual build a bit and noticed that the checkboxes do work. The only problem is that the unchecked checkbox appears for - [] instead of - [ ] (the space between the brackets).

I looked in the editor code a bit and there seems to be no problem in it. I will look into more depth and let you know.

<!-- gh-comment-id:1514693598 --> @literalEval commented on GitHub (Apr 19, 2023): @annieappflowy I played with AppFlowy manual build a bit and noticed that the checkboxes do work. The only problem is that the unchecked checkbox appears for `- []` instead of `- [ ]` (the space between the brackets). I looked in the editor code a bit and there seems to be no problem in it. I will look into more depth and let you know.
Author
Owner

@LucasXu0 commented on GitHub (Apr 20, 2023):

Hey, @literalEval. Because the (whitespace) is the event that triggers the conversion, I have implemented this logic and assume that this task has been completed.

const _checkboxListSymbols = ['[x]', '-[x]'];
const _unCheckboxListSymbols = ['[]', '-[]'];
<!-- gh-comment-id:1515597666 --> @LucasXu0 commented on GitHub (Apr 20, 2023): Hey, @literalEval. Because the ` ` (whitespace) is the event that triggers the conversion, I have implemented this logic and assume that this task has been completed. ```dart const _checkboxListSymbols = ['[x]', '-[x]']; const _unCheckboxListSymbols = ['[]', '-[]']; ```
Author
Owner

@annieappflowy commented on GitHub (Apr 20, 2023):

@literalEval thanks for helping out. I didn't know we supported -[] for the checkbox. I'm closing this issue.

<!-- gh-comment-id:1515707496 --> @annieappflowy commented on GitHub (Apr 20, 2023): @literalEval thanks for helping out. I didn't know we supported -[] for the checkbox. I'm closing this issue.
Author
Owner

@literalEval commented on GitHub (Apr 20, 2023):

@annieappflowy @LucasXu0 thanks.
Looking forward to solving more issues :)

<!-- gh-comment-id:1515750306 --> @literalEval commented on GitHub (Apr 20, 2023): @annieappflowy @LucasXu0 thanks. Looking forward to solving more issues :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#940
No description provided.