[PR #4352] [MERGED] fix: removed space under grid #6212

New issue

Closed

opened 2026-03-23 22:22:13 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4352
Author: @ilyes-ced
Created: 1/10/2024
Status: ✅ Merged
Merged: 1/14/2024
Merged by: @LucasXu0

Base: main ← Head: empty_space_in_grid_4314

📝 Commits (3)

9be9657 very_simple_fix
6b9c43d Merge branch 'main' into empty_space_in_grid_4314
70dce73 Merge branch 'AppFlowy-IO:main' into empty_space_in_grid_4314

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart (+1 -1)

📄 Description

Feature Preview

resolves #4314

i am not sure if that space is intended or did someone forget to change from 200 bottom padding in AppFlowy/frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart

old

class GridRowBottomBar extends StatelessWidget {
  const GridRowBottomBar({super.key});

  @override
  Widget build(BuildContext context) {
    return Container(
      padding: GridSize.footerContentInsets,
      height: GridSize.footerHeight,
      margin: const EdgeInsets.only(bottom: 200, top: 8),
      child: const GridAddRowButton(),
    );
  }

new

class GridRowBottomBar extends StatelessWidget {
  const GridRowBottomBar({super.key});

  @override
  Widget build(BuildContext context) {
    return Container(
      padding: GridSize.footerContentInsets,
      height: GridSize.footerHeight,
      margin: const EdgeInsets.only(bottom: 8, top: 8),
      child: const GridAddRowButton(),
    );
  }

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4352 **Author:** [@ilyes-ced](https://github.com/ilyes-ced) **Created:** 1/10/2024 **Status:** ✅ Merged **Merged:** 1/14/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `empty_space_in_grid_4314` --- ### 📝 Commits (3) - [`9be9657`](https://github.com/AppFlowy-IO/AppFlowy/commit/9be9657fa8beaab1aef0671116fc776c293e7dd6) very_simple_fix - [`6b9c43d`](https://github.com/AppFlowy-IO/AppFlowy/commit/6b9c43d2ce8dce8b628eb01e61b1385ca63cb891) Merge branch 'main' into empty_space_in_grid_4314 - [`70dce73`](https://github.com/AppFlowy-IO/AppFlowy/commit/70dce73857872156bb02ead910af68ba96dd3873) Merge branch 'AppFlowy-IO:main' into empty_space_in_grid_4314 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart` (+1 -1) </details> ### 📄 Description   ### Feature Preview resolves #4314 i am not sure if that space is intended or did someone forget to change from 200 bottom padding in `AppFlowy/frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart` #### old ```dart class GridRowBottomBar extends StatelessWidget { const GridRowBottomBar({super.key}); @override Widget build(BuildContext context) { return Container( padding: GridSize.footerContentInsets, height: GridSize.footerHeight, margin: const EdgeInsets.only(bottom: 200, top: 8), child: const GridAddRowButton(), ); } ``` #### new ```dart class GridRowBottomBar extends StatelessWidget { const GridRowBottomBar({super.key}); @override Widget build(BuildContext context) { return Container( padding: GridSize.footerContentInsets, height: GridSize.footerHeight, margin: const EdgeInsets.only(bottom: 8, top: 8), child: const GridAddRowButton(), ); } ```  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>