mirror of
https://github.com/tubearchivist/browser-extension.git
synced 2026-03-23 20:37:07 +00:00
[GH-ISSUE #42] Extension includes cookies from other extensions unrelated to youtube #25
Labels
No labels
bug
bug
duplicate
enhancement
help wanted
invalid
not an issue
not an issue
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tubearchivist/archived-browser-extension#25
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chrisliebaer on GitHub (Jul 7, 2024).
Original GitHub issue: https://github.com/tubearchivist/browser-extension/issues/42
This issue might be somewhat related to #22
I'm using the extension https://github.com/Cookie-AutoDelete/Cookie-AutoDelete on Firefox.
When attempting to download a video with the extension, Tube Archivist fails with
cookie file is invalid: invalid Netscape format cookies fileAnd when inspecting the request I can see, that the Tube Archivist browser extension included the following cookie
So I'm no broser extension developer, I don't know if spilling into page cookies by Cookie AutoDelete is a good approach but I would also expect at least some extensions and user script to do the same.
I think it would be reasonable to filter out all cookies that don't match the format required by whatever tool generated the error message above, probably
key=value.@bbilly1 commented on GitHub (Jul 8, 2024):
Well, it's not unrelated. It's a cookie for the domain
www.youtube.com, so that is working as expected. Strange that this is invalid. Does removing that cookie make it work?Ultimately, there is no expectation of compatibility with other extensions. If you want to make it compatible, please do.
@chrisliebaer commented on GitHub (Jul 9, 2024):
Removing the cookie either from the request or from the cookie store does make it work. Of course the other extension is adding it back after the next page request but everything done before that will work.
As I understand it, the error originates from
yt-dlp? I sadly don't have the entire debug output anymore but I think the other cookies passed to tubearchivist all had a value ofsomekey=somevalueand this one didn't. I guess I have a look at it.