[PR #51] [MERGED] Episodes by YYYYMMDD and some other cleanup #72

Closed
opened 2026-03-23 20:35:39 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/51
Author: @wolffshots
Created: 5/29/2025
Status: Merged
Merged: 10/23/2025
Merged by: @DarkFighterLuke

Base: masterHead: master


📝 Commits (10+)

  • ee683d5 feat: set e# and logging
  • af37598 chore: check library before updating watch status
  • 2f90d6a chore: remove extra season and move into if
  • 784592b chore: remove debugging log statements
  • d36d677 chore: remove unused import
  • 5ab5224 chore: ran dotnet format on Plugin.cs
  • a58139e chore: remove duplicated efforts
  • 3e95ca2 chore: make sync task logs debugs
  • 5b62e4c Update JFToTubeArchivistProgressSyncTask.cs
  • 93a2de5 Merge branch 'master' into master

📊 Changes

9 files changed (+83 additions, -16 deletions)

View changed files

Jellyfin.Plugin.TubeArchivistMetadata/Configuration/NumberingScheme.cs (+17 -0)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Configuration/PluginConfiguration.cs (+5 -0)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Configuration/configPage.html (+14 -0)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs (+20 -14)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Providers/EpisodeMetadataProvider.cs (+1 -0)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Tasks/JFToTubeArchivistProgressSyncTask.cs (+1 -1)
📝 Jellyfin.Plugin.TubeArchivistMetadata/TubeArchivist/Video/Video.cs (+6 -0)
📝 Jellyfin.Plugin.TubeArchivistMetadata/Utils/Utils.cs (+9 -1)
📝 README.md (+10 -0)

📄 Description

Changes:

  • Playback Progress and Watched Status Handling:

    • Updated OnPlaybackProgress method and added check to OnWatchedStatusChange method to use GetTopParent() for determining the top-level parent item, which should avoid a potential null pointer type exception if in a weird state. eventArgs.Item.GetTopParent() should be the collection title and avoids stepping up the hierarchy. If we want to still step up the hierarchy to get the channel and season then we can still do that after checking the top parent. [1] [2]
  • Metadata Enhancements:

    • Added Path assignment to result.Item in GetMetadata.
    • IndexNumber in ToEpisode uses YYYYMMDD as a number to sort nicely.
  • Logging:

    • Changed logging levels from LogInformation to LogDebug in JFToTubeArchivistProgressSyncTask to prevent so much being printed unnecessarily since it does slow down startup if the sync task is set to run "on application startup" [1] [2]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tubearchivist/tubearchivist-jf-plugin/pull/51 **Author:** [@wolffshots](https://github.com/wolffshots) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 10/23/2025 **Merged by:** [@DarkFighterLuke](https://github.com/DarkFighterLuke) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`ee683d5`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/ee683d5737c0293ab4508e7d8afefaca3eb60027) feat: set e# and logging - [`af37598`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/af375987ee198179b7e22440330ceb89dfef71a7) chore: check library before updating watch status - [`2f90d6a`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/2f90d6a03ed60f48f4c910b70c58c1c852417065) chore: remove extra season and move into if - [`784592b`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/784592b3623e1ac6fb8230c62096cbeb5b1c08da) chore: remove debugging log statements - [`d36d677`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/d36d6771798c60b2a7da9192527202922496b313) chore: remove unused import - [`5ab5224`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/5ab52243281f13a32e337673a37807d4eb88254f) chore: ran dotnet format on Plugin.cs - [`a58139e`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/a58139eca08968e6fc85a2269ff946e3c8e468ed) chore: remove duplicated efforts - [`3e95ca2`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/3e95ca26aaf67daffe44bc66c56a0e42f9d41980) chore: make sync task logs debugs - [`5b62e4c`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/5b62e4c0016300192b45feb256caeb121d305a66) Update JFToTubeArchivistProgressSyncTask.cs - [`93a2de5`](https://github.com/tubearchivist/tubearchivist-jf-plugin/commit/93a2de5d469a462d65d71bbbfbe6df6783e9e09b) Merge branch 'master' into master ### 📊 Changes **9 files changed** (+83 additions, -16 deletions) <details> <summary>View changed files</summary> ➕ `Jellyfin.Plugin.TubeArchivistMetadata/Configuration/NumberingScheme.cs` (+17 -0) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Configuration/PluginConfiguration.cs` (+5 -0) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Configuration/configPage.html` (+14 -0) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Plugin.cs` (+20 -14) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Providers/EpisodeMetadataProvider.cs` (+1 -0) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Tasks/JFToTubeArchivistProgressSyncTask.cs` (+1 -1) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/TubeArchivist/Video/Video.cs` (+6 -0) 📝 `Jellyfin.Plugin.TubeArchivistMetadata/Utils/Utils.cs` (+9 -1) 📝 `README.md` (+10 -0) </details> ### 📄 Description Changes: - Playback Progress and Watched Status Handling: * Updated `OnPlaybackProgress` method and added check to `OnWatchedStatusChange` method to use `GetTopParent()` for determining the top-level parent item, which should avoid a potential null pointer type exception if in a weird state. `eventArgs.Item.GetTopParent()` should be the collection title and avoids stepping up the hierarchy. If we want to still step up the hierarchy to get the channel and season then we can still do that after checking the top parent. [[1]](diffhunk://#diff-4c1026650550da3ffd1fe5f3f0df3f69edaac2b6a314c2b9b379b0fe3d20a768L176-R182) [[2]](diffhunk://#diff-4c1026650550da3ffd1fe5f3f0df3f69edaac2b6a314c2b9b379b0fe3d20a768L192-R203) - Metadata Enhancements: * Added `Path` assignment to `result.Item` in `GetMetadata`. * `IndexNumber` in `ToEpisode` uses YYYYMMDD as a number to sort nicely. - Logging: * Changed logging levels from `LogInformation` to `LogDebug` in `JFToTubeArchivistProgressSyncTask` to prevent so much being printed unnecessarily since it does slow down startup if the sync task is set to run "on application startup" [[1]](diffhunk://#diff-6e12253dcd80b45f0c2996e0a8b1204bdfa9e24ab3a273f3c8287e7e8bf74965L154-R154) [[2]](diffhunk://#diff-6e12253dcd80b45f0c2996e0a8b1204bdfa9e24ab3a273f3c8287e7e8bf74965L182-R182) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 20:35:39 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tubearchivist/archived-tubearchivist-jf-plugin#72
No description provided.